Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BACK-8037): EIP-712 conversion must not use format=amount inside arrays #152

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

jnicoulaud-ledger
Copy link
Contributor

Added test by reference to ensure we output same descriptor as legacy registry: https://github.com/LedgerHQ/ledger-asset-dapps/blob/main/ethereum/uniswap/eip712.json#L226

@jnicoulaud-ledger jnicoulaud-ledger requested a review from a team as a code owner November 21, 2024 10:35
@jnicoulaud-ledger jnicoulaud-ledger merged commit f62f2b6 into main Nov 21, 2024
5 checks passed
@jnicoulaud-ledger jnicoulaud-ledger deleted the BACK-8037 branch November 21, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants