chore: enable more lints

.github/release.yaml

@@ -28,4 +28,4 @@ changelog:
         - documentation # standard github label
     - title: Other changes
       labels:
-        - "*"
+        - "*"

.github/workflows/ci.yml

@@ -1,4 +1,3 @@
----
 name: continuous integration
 
 on:

.github/workflows/release-drafter.yml

@@ -1,12 +1,11 @@
----
 name: release drafter
 
 on:
   push:
     branches:
       - master
   pull_request:
-    types: [ opened, reopened, synchronize ]
+    types: [opened, reopened, synchronize]
 
 permissions:
   contents: read

.github/workflows/release.yml

@@ -1,4 +1,3 @@
----
 name: release
 
 on:
@@ -46,7 +45,7 @@ jobs:
 
       - name: Sign distribution artifacts
         timeout-minutes: 10
-        uses:  LedgerHQ/actions-security/actions/sign-blob@actions/sign-blob-1
+        uses: LedgerHQ/actions-security/actions/sign-blob@actions/sign-blob-1
         with:
           path: dist
 

.github/workflows/update.yml

@@ -1,4 +1,3 @@
----
 name: update dependencies
 
 on:

.pre-commit-config.yaml

@@ -32,42 +32,42 @@ repos:
 #          - pydantic
 #          - pytest
 #
-#  - repo: https://github.com/pdm-project/pdm
-#    rev: 2.18.1
-#    hooks:
-#      - id: pdm-lock-check
-#        name: check pdm lock file
-#
-#  - repo: https://github.com/adrienverge/yamllint.git
-#    rev: v1.29.0
-#    hooks:
-#      - id: yamllint
-#        name: check yaml files (yamllint)
-#
-#  - repo: https://github.com/pre-commit/pre-commit-hooks
-#    rev: v4.5.0
-#    hooks:
-#      - id: check-ast
-#      - id: check-builtin-literals
-#      - id: check-case-conflict
-#      - id: check-docstring-first
-#      - id: check-executables-have-shebangs
-#      - id: check-merge-conflict
-#      - id: check-shebang-scripts-are-executable
-#      - id: check-symlinks
-#      - id: check-toml
-#      - id: check-json
-#      - id: check-yaml
-#      - id: check-vcs-permalinks
-#      - id: debug-statements
-#      - id: destroyed-symlinks
-#      - id: detect-private-key
-#      - id: end-of-file-fixer
-#      - id: forbid-new-submodules
-#      - id: mixed-line-ending
-#      - id: fix-byte-order-marker
-#      # - id: no-commit-to-branch TODO (temporary for development)
-#
+  - repo: https://github.com/pdm-project/pdm
+    rev: 2.18.1
+    hooks:
+      - id: pdm-lock-check
+        name: check pdm lock file
+
+  - repo: https://github.com/adrienverge/yamllint.git
+    rev: v1.29.0
+    hooks:
+      - id: yamllint
+        name: check yaml files (yamllint)
+
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v4.5.0
+    hooks:
+      - id: check-ast
+      - id: check-builtin-literals
+      - id: check-case-conflict
+      - id: check-docstring-first
+      - id: check-executables-have-shebangs
+      - id: check-merge-conflict
+      - id: check-shebang-scripts-are-executable
+      - id: check-symlinks
+      - id: check-toml
+      - id: check-json
+      - id: check-yaml
+      - id: check-vcs-permalinks
+      - id: debug-statements
+      - id: destroyed-symlinks
+      - id: detect-private-key
+      - id: end-of-file-fixer
+      - id: forbid-new-submodules
+      - id: mixed-line-ending
+      - id: fix-byte-order-marker
+      # - id: no-commit-to-branch TODO (temporary for development)
+
 #  - repo: https://github.com/asottile/pyupgrade
 #    rev: v3.15.2
 #    hooks:
@@ -122,9 +122,9 @@ repos:
 #        name: lint docs spelling (codespell)
 #        additional_dependencies:
 #          - tomli
-#
-#  - repo: https://github.com/rhysd/actionlint
-#    rev: v1.6.27
-#    hooks:
-#      - id: actionlint
-#        name: lint Github Actions workflows (actionlint)
+
+  - repo: https://github.com/rhysd/actionlint
+    rev: v1.6.27
+    hooks:
+      - id: actionlint
+        name: lint Github Actions workflows (actionlint)

.yamllint

@@ -0,0 +1,6 @@
+extends: default
+
+rules:
+  document-start: disable
+  line-length:
+    max: 120

docs/erc-7730.schema.json

@@ -749,4 +749,4 @@
             ]
         }
     }
-}
+}

pyproject.toml

@@ -119,4 +119,4 @@ exclude_dirs = ["tests"]
 
 [tool.codespell]
 ignore-words = ".codespellignore"
-skip = "inputs/*,outputs/*,pdm.lock"
+skip = "inputs/*,outputs/*,pdm.lock"

src/erc7730/common/pydantic.py

@@ -29,4 +29,4 @@ def model_from_json_bytes(bytes: bytes, model: type[M]) -> M:
     Load a Pydantic model from a JSON file content as an array of bytes.
     """
     return model.model_validate_json(bytes, strict=True)
-
+

src/erc7730/mapper/mapper.py

@@ -38,4 +38,4 @@ def to_eip712_mapper(erc7730: ERC7730Descriptor) -> EIP712BaseMapper:
                 return EIP712BaseMapper(chain_id, contract_address, schema, display_name)
     else: 
         raise Exception(f"context for {erc7730} is None or is not EIP712")
-
+

src/erc7730/model/__init__.py

@@ -1 +1 @@
-""" Package implementing all typed method and their validations """
+""" Package implementing all typed method and their validations """

src/erc7730/model/base.py

@@ -12,4 +12,4 @@ class BaseLibraryModel(BaseModel):
         validate_assignment=True,
         arbitrary_types_allowed=False,
         allow_inf_nan=False,
-    )
+    )

src/erc7730/model/context.py

@@ -65,11 +65,3 @@ class EIP712Context(EIP712DomainBinding):
 
 
 
-
-
-
-
-
-
-
-

src/erc7730/model/display.py

@@ -83,5 +83,3 @@ class Field(BaseLibraryModel):
 class Display(BaseLibraryModel):
     definitions: Optional[Dict[str, Field]] = None
     formats: Dict[str, Format]
-
-

src/erc7730/model/erc7730_descriptor.py

@@ -22,4 +22,4 @@ class ERC7730Descriptor(BaseLibraryModel):
     context: Optional[Union[ContractContext, EIP712Context]] = None
     includes: Optional[list[Union[AnyUrl, Path]]] = None
     metadata: Optional[Metadata] = None
-    display: Optional[Display] = None
+    display: Optional[Display] = None

src/erc7730/model/metadata.py

@@ -19,10 +19,3 @@ class Metadata(BaseLibraryModel):
     token: Optional[TokenInfo] = None
     constants: Optional[Dict[str, str]] = None
     enums: Optional[Union[AnyUrl, Dict[str, Dict[str, str]]]] = None
-
-
-
-
-
-
-

tests/src/erc7730/test_datamodel.py

@@ -10,4 +10,4 @@ def test_from_erc7730() -> None:
     assert model_from_json_file_or_none(Path("clear-signing-erc7730-registry/registry/paraswap/calldata-AugustusSwapper.json"), ERC7730Descriptor) is not None
     assert model_from_json_file_or_none(Path("clear-signing-erc7730-registry/registry/tether/calldata-usdt.json"), ERC7730Descriptor) is not None
     assert model_from_json_file_or_none(Path("clear-signing-erc7730-registry/registry/uniswap/calldata-UniswapV3Router02.json"), ERC7730Descriptor) is not None
-    assert model_from_json_file_or_none(Path("clear-signing-erc7730-registry/registry/uniswap/eip712-permit2.json"), ERC7730Descriptor) is not None
+    assert model_from_json_file_or_none(Path("clear-signing-erc7730-registry/registry/uniswap/eip712-permit2.json"), ERC7730Descriptor) is not None