Skip to content
This repository has been archived by the owner on Feb 12, 2025. It is now read-only.

Commit

Permalink
Take PR comments into consideration
Browse files Browse the repository at this point in the history
  • Loading branch information
KhalilBellakrid committed Feb 4, 2019
1 parent 57c56b7 commit 303615a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ this same document.
candidates*.

## Release process
- Development : fixes, features are done on specific branches on developers' fork,
- Pull requests: submitted to LedgerHQ/develop with updated of CHANGELOG.md,
- Development: fixes, features are done on specific branches on developers' fork,
- Pull requests: submitted to LedgerHQ/develop with updated CHANGELOG.md,
- Merge into `LedgerHQ/develop`: triggers CI builds and deploys under `x.y.z-rc-commitHash`,
- Merge into `LedgerHQ/master`: once a version is confirmed to be stable by at least by one of our clients
(Vault or Live), we bump project’s version, for this we jhave a special pull request. Once merged in
- Merge into `LedgerHQ/master`: once a version is confirmed to be stable at least by one of our clients
(Vault or Live), we bump project’s version, for this we have a special pull request. Once merged in
`LedgerHQ/master` and tagged as a stable release `x.y.z`, a build and a deployment are triggered.
To sum up, tags point to stable releases that are in production. **These versions should be used by any application
client of libcore**
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,14 +141,14 @@ node ledger-core-samples/nodejs/tests/wallet-pool-test.js
```
## Support

###Libcore:
### Libcore:
Libcore can be built for following OSes:
- MacOS: minimum supported version is `macOS 9.0`, with `x86_64` architecture,
- Linux: Debian (stretch), Ubuntu and Arch are supported, with `x86_64` architecture,
- Windows: 64-bit architecture is built with `MSVC` (starting from Visual Studio 15), 32-bit is built with `MinGW`,
- iOS: `x86_64`, `armv7` and `arm64` architectures are supported, minimum supported version is `iOS 10.0`,
- Android: `x86`, `armeabi-v7a` and `arm64-v8a` architectures are supported, minimum supported version is `Android 7 (API 24)` (Java 8 is needed).
###Bindings:
### Bindings:
- NodeJS bindings:
- Please use `node` with version `>=8.4.0` and `<9.0.0` (other versions are not tested (yet)),
- Node-gyp is used to build native module and requires `python` with version `2.7.x`.
Expand Down

0 comments on commit 303615a

Please sign in to comment.