Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump protobuf 28.1 #81

Merged
merged 5 commits into from
Jan 2, 2025
Merged

chore: bump protobuf 28.1 #81

merged 5 commits into from
Jan 2, 2025

Conversation

edelanghe-ledger
Copy link
Contributor

@edelanghe-ledger edelanghe-ledger commented Dec 16, 2024 •
edited
Loading

  • Use protobuf 28.1
  • Document how to generate the stubs

@edelanghe-ledger edelanghe-ledger changed the title chore: bump protobuf 28.2 chore: bump protobuf 28.1 Dec 18, 2024
@yogh333 yogh333 self-requested a review December 19, 2024 08:42
yogh333
yogh333 reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@yogh333 yogh333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you please update the CHANGELOG.md file please ?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@edelanghe-ledger
Copy link
Contributor Author

@yogh333 I have added a343d52 on top 👍

@yogh333 yogh333 self-requested a review January 2, 2025 08:52
@yogh333 yogh333 merged commit cc28258 into LedgerHQ:master Jan 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogh333 yogh333 yogh333 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edelanghe-ledger @yogh333