fix(llm): 🩹 do not re-count devices multiple time after upgrades #9244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changeset
was attached.📝 Description
Context
In #9109 devices are added to the store in
settings.seenDevices
which is supposed to be a uniq device array. However to identify the devices uniquely the reducer usesDeviceModelInfo["deviceInfo"]["targetId"]
which actually identifies the firmware version. While discussing the issue the device team pointed out that there is no way to uniquely identify a device.Fix
As an approximation this PR stores for each model only the last connected device into
settings.seenDevices
. Then devices are counted based on:ble.knownDevices
+ (each model insettings.seenDevices
but not inble.knownDevices
)❓ Context
🧐 Checklist for the PR Reviewers