💄 (llm) empty accounts/assets screen #9215
Open
+381
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
LucasWerey
force-pushed
the
feat/LIVE-16967
branch
5 times, most recently
from
213d603 to
64bacd4
Compare
LucasWerey
force-pushed
the
feat/LIVE-16967
branch
5 times, most recently
from
4145d3a to
439597a
Compare
LucasWerey
force-pushed
the
feat/LIVE-16967
branch
from
439597a to
b1bcb9f
Compare
| isSyncEnabled={isSyncEnabled} | ||
| specificAccounts={specificAccounts} | ||
| /> | ||
| {!hasNoAccount ? ( |
There was a problem hiding this comment.
Can we avoid doing negative conditions when possible ? I find it more readable to put it the other way : hasNoAccount ? <EmptyList /> : <List />
Wdyt ?
LucasWerey
force-pushed
the
feat/LIVE-16967
branch
from
b1bcb9f to
f960d9c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
When we use a deeplink to open assets and accounts list we can be in an empty screen if we don't have any account. To avoid that I've added an emptyList component that we could use for all our emptyList.
The idea is to have different empty list components depending on the context => addAccount for assets and accounts screen, maybe receive empty list for other screens. This way we can ensure homogeneity using the same base component
deeplinks used :
ledgerlive://accounts?canAddAccount=true&showHeader=true&isSyncEnabled=true
ledgerlive://assets?showHeader=true
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2025-02-13.at.15.19.05.mp4
❓ Context
🧐 Checklist for the PR Reviewers