Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dropdown drawer menu for managing an Earn position #9185

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

marcotoniut-ledger
Copy link
Contributor

@marcotoniut-ledger marcotoniut-ledger commented Feb 11, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • New modal component added.

πŸ“ Description

Add a new modal, that can be triggered from Earn, that shows a list of options to select from. These will re-direct the user to different dynamic links specified from Earn.

After:

Simulator Screenshot - iPhone 15 Pro - 2025-02-11 at 06 43 08

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@marcotoniut-ledger marcotoniut-ledger requested review from a team as code owners February 11, 2025 10:21
Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 5:51pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 5:51pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 5:51pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 5:51pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Feb 11, 2025
@marcotoniut-ledger marcotoniut-ledger force-pushed the LIVE-15861-earn-manage-staking-positions-via-earn-dashboard-mobile-desktop branch from 672d9b5 to 28bd0b6 Compare February 11, 2025 12:23
@marcotoniut-ledger marcotoniut-ledger force-pushed the LIVE-15861-earn-manage-staking-positions-via-earn-dashboard-mobile-desktop branch from 3c71930 to b6932b2 Compare February 13, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants