Normalise refs before passing to turbo-affected #8991
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
lewisd5
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://ledgerhq.atlassian.net/browse/LIVE-16491
This was a (hopefully the) missing piece from yesterday's merge queue switch-on. Git refs need to normalised, i.e. the
refs/heads/substring needs to be removed, before passing to turbo. This PR implements that.Here's a PR that shows this working. The
clean-refsstep is mostly copy-pasted from theclean-refsstep that is already in this repo'sturbo-affected-reusableworkflow (it adds in variable definitions that this repo'sturbo-affected-reusableworkflow receives when it is run).Here's the check that runs during the PR CI. Here's the check that runs on the merge group. It helps to get those 2 runs up side by side. You want to compare the "echo vars" and the "echo sanitized vars" steps for each run. This shows both that
This is what we need to fix the ambiguous refs issue from yesterday's merge group check.