Add Ledger Sync commands to the CLI #7983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
KVNLS
force-pushed
the
feat/ledger-sync-cli
branch
2 times, most recently
from
953a742 to
7bb5d8d
Compare
themooneer
reviewed
Oct 3, 2024
| }); | ||
|
|
||
| if (push) { | ||
| if (!data) return "data is required"; |
There was a problem hiding this comment.
question: why this check is not made as a return-early with those between line:112->118 ? it would avoid getSdk and cloudSyncSDK instantiation for nothing. am i wrong ?
KVNLS
force-pushed
the
feat/ledger-sync-cli
branch
from
7bb5d8d to
c0aad99
Compare
themooneer
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Add Ledger Sync commands to the CLI.
❓ Context
🧐 Checklist for the PR Reviewers