Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (signer-btc) [DSDK-472]: Implement update PSBT and extract transaction #607

Merged
merged 7 commits into from
Jan 17, 2025
Merged

✨ (signer-btc) [DSDK-472]: Implement update PSBT and extract transaction #607

merged 7 commits into from
Jan 17, 2025
+2,034 −9

Conversation

jdabbech-ledger
Copy link
Contributor

@jdabbech-ledger jdabbech-ledger commented Jan 13, 2025 •
edited by jira bot
Loading

📝 Description

  • Update PSBT task
  • Extract transaction task
  • Sign transaction DA
sign_transaction.mp4

❓ Context

  • Feature:

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@jdabbech-ledger jdabbech-ledger requested a review from a team as a code owner January 13, 2025 11:23
@vercel Vercel
Copy link

vercel bot commented Jan 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 1:51pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 1:51pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025 •
edited
Loading

Messages
✅ Danger: All checks passed successfully! 🎉

Generated by 🚫 dangerJS against eae62c9

@jdabbech-ledger jdabbech-ledger force-pushed the feat/dsdk-472-update-psbt-extract-transaction branch from a5b3341 to a74037b Compare January 13, 2025 11:31
@jdabbech-ledger jdabbech-ledger force-pushed the feat/dsdk-471-sign-psbt-task branch from fe39d19 to 1fdb8fa Compare January 14, 2025 10:16
aussedatlo
aussedatlo approved these changes Jan 14, 2025
View reviewed changes
packages/signer/signer-btc/src/internal/app-binder/task/ExtractTransactionTask.ts Outdated
private readonly _args: ExtractTransactionTaskArgs,
private readonly _valueParser: ValueParser,
) {}
run(): CommandResult<string, BtcErrorCodes> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[COULD] you could use HexaString type instead of string as you return a bufferToHexaString

packages/signer/signer-btc/src/internal/app-binder/task/UpdatePsbtTask.ts Outdated
Uint8Array.from([]),
);

if (signature.length != 64 && signature.length != 65) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[COULD] use const for 64 and 65 values

packages/signer/signer-btc/src/internal/app-binder/task/UpdatePsbtTask.ts Outdated
}

function writePush(buf: ByteArrayBuilder, data: Uint8Array) {
if (data.length <= 75) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[COULD] same for theses values if possible

Base automatically changed from feat/dsdk-471-sign-psbt-task to develop January 14, 2025 13:47
paoun-ledger
paoun-ledger reviewed Jan 15, 2025
View reviewed changes
packages/signer/signer-btc/src/internal/app-binder/task/UpdatePsbtTask.ts
const signature = maybeSignature.mapOrDefault(
(v) => v.data,
Uint8Array.from([]),
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[COULD] since you already verified it at line 258, maybe you could just use something like maybeSignature.unsafeCoerce().data

@jdabbech-ledger jdabbech-ledger force-pushed the feat/dsdk-472-update-psbt-extract-transaction branch from a74037b to 3f01185 Compare January 16, 2025 20:22
@jdabbech-ledger jdabbech-ledger force-pushed the feat/dsdk-472-update-psbt-extract-transaction branch from 33b1043 to eae62c9 Compare January 17, 2025 13:39
paoun-ledger
paoun-ledger approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@paoun-ledger paoun-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jdabbech-ledger jdabbech-ledger added this pull request to the merge queue Jan 17, 2025
Merged via the queue into develop with commit 40a001e Jan 17, 2025
10 checks passed
@jdabbech-ledger jdabbech-ledger deleted the feat/dsdk-472-update-psbt-extract-transaction branch January 17, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paoun-ledger paoun-ledger paoun-ledger approved these changes

@aussedatlo aussedatlo aussedatlo approved these changes

Assignees

@jdabbech-ledger jdabbech-ledger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdabbech-ledger @aussedatlo @paoun-ledger