Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 (signer-eth) [DSDK-633]: Fallback on legacy signing #604

Merged
merged 3 commits into from
Jan 13, 2025
Merged

🐛 (signer-eth) [DSDK-633]: Fallback on legacy signing #604

merged 3 commits into from
Jan 13, 2025
+423 −63

Conversation

aussedatlo
Copy link
Contributor

@aussedatlo aussedatlo commented Jan 13, 2025 •
edited by jira bot
Loading

📝 Description

Update the signer ethereum device action to fallback on blind signing when some commands are not supported.

  • SignTransaction: Fallback to blind sign transaction if getChallenge does not work
  • SignTypedObject: Fallback to legacy signing if provide does not work.

❓ Context

  • Feature:

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@aussedatlo aussedatlo requested a review from a team as a code owner January 13, 2025 08:44
@vercel Vercel
Copy link

vercel bot commented Jan 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 11:37am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 11:37am

@aussedatlo aussedatlo marked this pull request as draft January 13, 2025 08:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025 •
edited
Loading

Messages
✅ Danger: All checks passed successfully! 🎉

Generated by 🚫 dangerJS against adb430e

@aussedatlo aussedatlo force-pushed the feat/dsdk-633-nano-s-support branch from 205585e to adb430e Compare January 13, 2025 09:14
@aussedatlo aussedatlo marked this pull request as ready for review January 13, 2025 09:15
@aussedatlo aussedatlo force-pushed the feat/dsdk-633-nano-s-support branch from 9e69328 to adb430e Compare January 13, 2025 13:58
@aussedatlo aussedatlo added this pull request to the merge queue Jan 13, 2025
Merged via the queue into develop with commit 1929a32 Jan 13, 2025
13 checks passed
@aussedatlo aussedatlo deleted the feat/dsdk-633-nano-s-support branch January 13, 2025 15:20
@github-actions github-actions bot mentioned this pull request Jan 16, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdabbech-ledger jdabbech-ledger jdabbech-ledger approved these changes

@ofreyssinet-ledger ofreyssinet-ledger ofreyssinet-ledger approved these changes

Assignees

@aussedatlo aussedatlo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aussedatlo @ofreyssinet-ledger @jdabbech-ledger