Add 1inch AggregationRouterV6 clear signing metadata #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiyangc
changed the title
artall64
reviewed
Nov 27, 2024
| }, | ||
| { | ||
| "chainId": 324, | ||
| "address": "0x111111125421cA6dc452d289314280a0f8842A65" |
There was a problem hiding this comment.
On zkSync ( chainId: 324) RouterV6 has different address, correct one is: 0x6fd4383cb451173d5f9304f041c7bcbf27d561ff
There was a problem hiding this comment.
Is there a way to officially confirm this? I was unaware of the different addresses when I checked a few through etherscan. A repo, doc page, or somewhere else to verify the address?
There was a problem hiding this comment.
At the moment there is two ways to verify:
- it's available on the official Github: https://github.com/1inch/limit-order-protocol
- You also can perform swap on zkSync on app.1inch.io and see where transaction goes
I also asked 1inch team put it some where into official docs
|
Hi @taiyangc, we have fixed the CI issues, could you update your branch so that the linter runs ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the latest 1inch ABI definitions here https://etherscan.io/address/0x111111125421ca6dc452d289314280a0f8842a65#code
Tested locally on developer-preview