Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lastUpdate by deploymentDate #137

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace lastUpdate by deploymentDate #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fabe31
replace lastUpdate by deploymentDate
vforgeoux-ledger Jan 23, 2025
b05ab06
fix: replace lastUpdate by deploymentDate for 1inch v6
paoun-ledger Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion developer-preview/src/app/Screens.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ interface Props {
chainId: number;
contractAddress: string;
chosenOperation: Operation;
info: { lastUpdate: string; legalName: string; url: string };
info: { deploymentDate: string; legalName: string; url: string };
owner: string;
operationType: string;
}
Expand Down
4 changes: 2 additions & 2 deletions developer-preview/src/lib/getPreviewData.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const minimumERC7730Schema: ERC7730Schema = {
$schema: "unused",
metadata: {
owner: "",
info: { legalName: "", lastUpdate: "", url: "" },
info: { legalName: "", deploymentDate: "", url: "" },
},
context: exampleTransactionContext,
};
Expand All @@ -35,7 +35,7 @@ describe("getPreviewData", () => {
info: {
url: "https://poap.xyz/",
legalName: "legalName",
lastUpdate: "2022-03-03T17:56:02Z",
deploymentDate: "2022-03-03T17:56:02Z",
},
};

Expand Down
2 changes: 1 addition & 1 deletion developer-preview/src/types/ERC7730Schema.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ interface Metadata {

interface OwnerInfo {
legalName: string;
lastUpdate: string;
deploymentDate: string;
url: string;
}

Expand Down
2 changes: 1 addition & 1 deletion developer-preview/src/types/PreviewData.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export type PreviewData = {
owner: string;
info?: {
legalName: string;
lastUpdate?: string;
deploymentDate?: string;
url: string;
};
};
Expand Down
2 changes: 1 addition & 1 deletion registry/1inch/calldata-AggregationRouterV3.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
"metadata": {
"owner": "1inch",
"info": { "url": "https://1inch.io/", "legalName": "1inch Network", "lastUpdate": "2021-03-14T20:28:50Z" },
"info": { "url": "https://1inch.io/", "legalName": "1inch Network", "deploymentDate": "2021-03-14T20:28:50Z" },
"constants": {
"addressAsEth": "0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE",
"addressAsNull": "0x0000000000000000000000000000000000000000"
Expand Down
2 changes: 1 addition & 1 deletion registry/1inch/calldata-AggregationRouterV5.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"metadata": {
"owner": "1inch",
"info": { "url": "https://1inch.io/", "legalName": "1inch Network", "lastUpdate": "2022-11-04T06:04:59Z" },
"info": { "url": "https://1inch.io/", "legalName": "1inch Network", "deploymentDate": "2022-11-04T06:04:59Z" },
"constants": {
"addressAsEth": "0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE",
"addressAsNull": "0x0000000000000000000000000000000000000000"
Expand Down
2 changes: 1 addition & 1 deletion registry/1inch/common-AggregationRouterV4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"info": {
"url": "https://1inch.io/",
"legalName": "1inch Network",
"lastUpdate": "2021-11-05T10:18:09Z"
"deploymentDate": "2021-11-05T10:18:09Z"
},
"constants": {
"addressAsEth": "0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE",
Expand Down
2 changes: 1 addition & 1 deletion registry/1inch/common-AggregationRouterV6.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"$schema": "../../specs/erc7730-v1.schema.json",
"metadata": {
"owner": "1inch",
"info": { "url": "https://1inch.io/", "legalName": "1inch Network", "lastUpdate": "2024-02-12T03:44:35Z" },
"info": { "url": "https://1inch.io/", "legalName": "1inch Network", "deploymentDate": "2024-02-12T03:44:35Z" },
"constants": {
"addressAsEth": "0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE",
"addressAsNull": "0x0000000000000000000000000000000000000000"
Expand Down
2 changes: 1 addition & 1 deletion registry/aave/calldata-lpv2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check notice on line 1 in registry/aave/calldata-lpv2.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Proxy contract 

Contract https://etherscan.io/address/0x7d2768de32b0b80b7a3454c06bdac94a69ddc7a9#code is likely to be a proxy, validation of descriptor ABIs skipped

Check warning on line 1 in registry/aave/calldata-lpv2.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field 

No display field is defined for path `#.referralCode` in function 0xa415bcad. If intentionally excluded, please add it to `excluded` list to avoid this warning.

Check warning on line 1 in registry/aave/calldata-lpv2.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field 

No display field is defined for path `#.referralCode` in function 0xe8eda9df. If intentionally excluded, please add it to `excluded` list to avoid this warning.
"$schema": "../../specs/erc7730-v1.schema.json",
"context": {
"$id": "Lending Pool v2",
Expand All @@ -9,7 +9,7 @@
},
"metadata": {
"owner": "Aave",
"info": { "url": "https://aave.com", "legalName": "Aave DAO", "lastUpdate": "2020-11-30T09:25:48Z" },
"info": { "url": "https://aave.com", "legalName": "Aave DAO", "deploymentDate": "2020-11-30T09:25:48Z" },
"enums": { "interestRateMode": { "1": "stable", "2": "variable" } },
"constants": { "max": "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff" }
},
Expand Down
2 changes: 1 addition & 1 deletion registry/aave/calldata-lpv3.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check notice on line 1 in registry/aave/calldata-lpv3.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Proxy contract 

Contract https://etherscan.io/address/0x87870bca3f3fd6335c3f4ce8392d69350b4fa4e2#code is likely to be a proxy, validation of descriptor ABIs skipped
"$schema": "../../specs/erc7730-v1.schema.json",
"context": {
"$id": "PoolInstance",
Expand All @@ -9,7 +9,7 @@
},
"metadata": {
"owner": "Aave",
"info": { "url": "https://aave.com", "legalName": "Aave DAO", "lastUpdate": "2024-10-09T21:46:47Z" },
"info": { "url": "https://aave.com", "legalName": "Aave DAO", "deploymentDate": "2024-10-09T21:46:47Z" },
"enums": { "interestRateMode": { "1": "stable", "2": "variable" } },
"constants": { "max": "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff" }
},
Expand Down
2 changes: 1 addition & 1 deletion registry/lido/calldata-OssifiableProxy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check notice on line 1 in registry/lido/calldata-OssifiableProxy.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Proxy contract 

Contract https://etherscan.io/address/0x889edc2edab5f40e902b864ad4d7ade8e412f9b1#code is likely to be a proxy, validation of descriptor ABIs skipped
"$schema": "../../specs/erc7730-v1.schema.json",
"context": {
"$id": "OssifiableProxy",
Expand All @@ -9,7 +9,7 @@
},
"metadata": {
"owner": "Lido",
"info": { "url": "https://lido.fi", "legalName": "Lido DAO", "lastUpdate": "2023-05-02T10:38:47Z" },
"info": { "url": "https://lido.fi", "legalName": "Lido DAO", "deploymentDate": "2023-05-02T10:38:47Z" },
"constants": {
"stETHaddress": "0xae7ab96520DE3A18E5e111B5EaAb095312D7fE84",
"wstETHaddress": "0x0B925eD163218f6662a35e0f0371Ac234f9E9371"
Expand Down
2 changes: 1 addition & 1 deletion registry/lido/calldata-stETH.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check notice on line 1 in registry/lido/calldata-stETH.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Proxy contract 

Contract https://etherscan.io/address/0xae7ab96520de3a18e5e111b5eaab095312d7fe84#code is likely to be a proxy, validation of descriptor ABIs skipped
"$schema": "../../specs/erc7730-v1.schema.json",
"context": {
"$id": "stETH",
Expand All @@ -7,7 +7,7 @@
"abi": "https://github.com/LedgerHQ/ledger-asset-dapps/blob/211e75ed27de3894f592ca73710fa0b72c3ceeae/ethereum/lido/abis/0xae7ab96520de3a18e5e111b5eaab095312d7fe84.abi.json"
}
},
"metadata": { "owner": "Lido", "info": { "url": "https://lido.fi", "legalName": "Lido DAO", "lastUpdate": "2021-02-19T04:37:20Z" } },
"metadata": { "owner": "Lido", "info": { "url": "https://lido.fi", "legalName": "Lido DAO", "deploymentDate": "2021-02-19T04:37:20Z" } },
"display": {
"formats": {
"submit(address)": {
Expand Down
2 changes: 1 addition & 1 deletion registry/lido/calldata-wstETH.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"metadata": {
"owner": "Lido",
"info": { "url": "https://lido.fi", "legalName": "Lido DAO", "lastUpdate": "2021-02-19T04:37:20Z" },
"info": { "url": "https://lido.fi", "legalName": "Lido DAO", "deploymentDate": "2021-02-19T04:37:20Z" },
"constants": { "stETHaddress": "0xae7ab96520DE3A18E5e111B5EaAb095312D7fE84" }
},
"display": {
Expand Down
2 changes: 1 addition & 1 deletion registry/makerdao/eip712-permit-DAI.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"includes": "../../ercs/eip712-erc2612-permit.json",
"metadata": {
"owner": "MakerDAO",
"info": { "legalName": "Maker Foundation", "url": "https://makerdao.com/", "lastUpdate": "2017-12-18T00:00:00Z" },
"info": { "legalName": "Maker Foundation", "url": "https://makerdao.com/", "deploymentDate": "2017-12-18T00:00:00Z" },
"token": { "name": "Dai Stablecoin", "ticker": "DAI", "decimals": 18 }
},
"display": {
Expand Down
2 changes: 1 addition & 1 deletion registry/paraswap/calldata-AugustusSwapper.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check notice on line 1 in registry/paraswap/calldata-AugustusSwapper.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Proxy contract 

Contract https://etherscan.io/address/0xdef171fe48cf0115b1d80b88dc8eab59176fee57#code is likely to be a proxy, validation of descriptor ABIs skipped

Check warning on line 1 in registry/paraswap/calldata-AugustusSwapper.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field 

No display field is defined for path `#.data.callees.[]` in function 0x2298207a. If intentionally excluded, please add it to `excluded` list to avoid this warning.

Check warning on line 1 in registry/paraswap/calldata-AugustusSwapper.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field 

No display field is defined for path `#.data.callees.[]` in function 0x54e3f31b. If intentionally excluded, please add it to `excluded` list to avoid this warning.

Check warning on line 1 in registry/paraswap/calldata-AugustusSwapper.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field 

No display field is defined for path `#.data.deadline` in function 0x2298207a. If intentionally excluded, please add it to `excluded` list to avoid this warning.

Check warning on line 1 in registry/paraswap/calldata-AugustusSwapper.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field 

No display field is defined for path `#.data.deadline` in function 0x46c67b6d. If intentionally excluded, please add it to `excluded` list to avoid this warning.

Check warning on line 1 in registry/paraswap/calldata-AugustusSwapper.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field 

No display field is defined for path `#.data.deadline` in function 0x54e3f31b. If intentionally excluded, please add it to `excluded` list to avoid this warning.

Check warning on line 1 in registry/paraswap/calldata-AugustusSwapper.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field 

No display field is defined for path `#.data.deadline` in function 0xa94e78ef. If intentionally excluded, please add it to `excluded` list to avoid this warning.

Check warning on line 1 in registry/paraswap/calldata-AugustusSwapper.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field 

No display field is defined for path `#.data.exchangeData.[]` in function 0x2298207a. If intentionally excluded, please add it to `excluded` list to avoid this warning.

Check warning on line 1 in registry/paraswap/calldata-AugustusSwapper.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field 

No display field is defined for path `#.data.exchangeData.[]` in function 0x54e3f31b. If intentionally excluded, please add it to `excluded` list to avoid this warning.
"$schema": "../../specs/erc7730-v1.schema.json",
"context": {
"$id": "AugustusSwapper",
Expand All @@ -9,7 +9,7 @@
},
"metadata": {
"owner": "Paraswap",
"info": { "url": "https://www.paraswap.io/", "legalName": "ParaSwap", "lastUpdate": "2021-08-18T12:42:05Z" },
"info": { "url": "https://www.paraswap.io/", "legalName": "ParaSwap", "deploymentDate": "2021-08-18T12:42:05Z" },
"constants": { "addressAsEth": "0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE" }
},
"display": {
Expand Down
2 changes: 1 addition & 1 deletion registry/poap/calldata-PoapBridge.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"metadata": {
"owner": "POAP",
"info": { "url": "https://poap.xyz/", "legalName": "Proof of Attendance Protocol", "lastUpdate": "2022-03-03T17:56:02Z" }
"info": { "url": "https://poap.xyz/", "legalName": "Proof of Attendance Protocol", "deploymentDate": "2022-03-03T17:56:02Z" }
},
"display": {
"formats": {
Expand Down
2 changes: 1 addition & 1 deletion registry/quickswap/calldata-QuickSwap.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"metadata": {
"owner": "QuickSwap",
"info": { "legalName": "QuickSwap", "lastUpdate": "2024-10-01T00:00:00Z", "url": "https://quickswap.exchange" }
"info": { "legalName": "QuickSwap", "deploymentDate": "2020-09-25T10:52:01Z", "url": "https://quickswap.exchange" }
},
"display": {
"formats": {
Expand Down
2 changes: 1 addition & 1 deletion registry/starkgate/calldata-StarkGate-STRK.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check notice on line 1 in registry/starkgate/calldata-StarkGate-STRK.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Proxy contract 

Contract https://etherscan.io/address/0xce5485cfb26914c5dce00b9baf0580364dafc7a4#code is likely to be a proxy, validation of descriptor ABIs skipped
"$schema": "../../specs/erc7730-v1.schema.json",
"context": {
"$id": "L1StarkGateSTRKbridge",
Expand All @@ -9,7 +9,7 @@
},
"metadata": {
"owner": "Starknet",
"info": { "url": "https://starkgate.starknet.io/", "legalName": "StarkWare", "lastUpdate": "2024-10-01T00:00:00Z" }
"info": { "url": "https://starkgate.starknet.io/", "legalName": "StarkWare", "deploymentDate": "2024-10-01T00:00:00Z" }
},
"display": {
"formats": {
Expand Down
2 changes: 1 addition & 1 deletion registry/tether/calldata-usdt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"includes": "../../ercs/calldata-erc20-tokens.json",
"metadata": {
"owner": "Tether",
"info": { "legalName": "Tether Limited", "url": "https://tether.to/", "lastUpdate": "2017-11-28T12:41:21Z" },
"info": { "legalName": "Tether Limited", "url": "https://tether.to/", "deploymentDate": "2017-11-28T12:41:21Z" },
"token": { "ticker": "USDT", "name": "Tether USD", "decimals": 6 }
}
}
2 changes: 1 addition & 1 deletion registry/uniswap/calldata-UniswapV3Router02.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"metadata": {
"owner": "Uniswap",
"info": { "legalName": "Uniswap Labs", "lastUpdate": "2021-12-14T00:00:00Z", "url": "https://uniswap.org/" }
"info": { "legalName": "Uniswap Labs", "deploymentDate": "2021-12-14T00:00:00Z", "url": "https://uniswap.org/" }
},
"display": {
"formats": {
Expand Down
2 changes: 1 addition & 1 deletion registry/uniswap/uniswap-common-eip712.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"owner": "Uniswap",
"info": {
"legalName": "Uniswap Labs",
"lastUpdate": "2021-12-14T00:00:00Z",
"deploymentDate": "2021-12-14T00:00:00Z",
"url": "https://uniswap.org/"
}
}
Expand Down
6 changes: 3 additions & 3 deletions specs/erc-7730.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ The following is a simple example of how to clear sign a `transfer` function cal
"info": {
"legalName": "Tether Limited",
"url": "https://tether.to/",
"lastUpdate": "2017-11-28T12:41:21Z"
"deploymentDate": "2017-11-28T12:41:21Z"
}
},

Expand Down Expand Up @@ -316,7 +316,7 @@ The following file would include this generic interface and bind it to the speci
"info": {
"legalName": "Tether Limited",
"url": "https://tether.to/",
"lastUpdate": "2017-11-28T12:41:21Z"
"deploymentDate": "2017-11-28T12:41:21Z"
},
"token": {
"ticker": "USDT",
Expand Down Expand Up @@ -536,7 +536,7 @@ Wallet MAY use this value to display the target of the interaction being reviewe

A key containing additional structured info about the *owner* of the contract:
* `legalName` is the legal owner entity name
* `lastUpdate` is the date of the contract (or verifying contract) last update
* `deploymentDate` is the date of deployment of the contract (or verifying contract)
* `url` is the official URL of the owner

A wallet MAY use this information to display additional details about the targeted contract.
Expand Down
6 changes: 3 additions & 3 deletions specs/erc7730-v1.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,11 +258,11 @@
"type": "string",
"description": "The full legal name of the owner if different from the owner field."
},
"lastUpdate": {
"title": "Last Update of the contract / message",
"deploymentDate": {
"title": "Deployment date of the contract / message",
"type": "string",
"format": "date-time",
"description": "The date of the last update of the contract / message."
"description": "The date of deployment of the contract / message."
},
"url": {
"title": "Owner URL",
Expand Down