-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ developer-preview: decode transaction calldata #104
base: master
Are you sure you want to change the base?
Conversation
dfe2c68
to
aaf576d
Compare
@cruzdanilo thank you very much for your PR and apologies that I missed the notification before now. After a first read of the description and a first scan of the code changes this looks like excellent work. @pdeville-ledger and/or myself will try to give it a full review this week. Firstly, I'd like to share some context around the preview tool. This locally run web-app is very likely to be replaced and removed from this repository. We just started work on a hosted web-app that will generate the Clear-Signing JSON file, starting with a contract address or ABI and providing UI for adding the Clear-signing meta-data. The preview will be live in the browser and the end result will be a JSON file to add to this repository (the registry). So while some of the functionality will be the same as this preview tool we want to be transparent that the preview tool will probably be removed from this repository and much of the code will be replaced. |
changes
NEXT_PUBLIC_ETHERSCAN_API_KEY
, fails gracefully without it)TextEncoder
(only for jest tests)