Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B2CA-1648: Port Flex #51

Merged
merged 10 commits into from
May 27, 2024
Merged

B2CA-1648: Port Flex #51

merged 10 commits into from
May 27, 2024

Conversation

cedelavergne-ledger
Copy link
Contributor

Port App to Flex.

This includes:

  • Port NBGLv2
  • Adapt tests using scenario_navigator
  • Update version

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1648_Port-Flex branch 3 times, most recently from 7370777 to 53c23e9 Compare May 24, 2024 08:39
Copy link

@tdejoigny-ledger tdejoigny-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small change is required in codeql CI (add Flex target)

this line:
sdk: ["$NANOS_SDK", "$NANOX_SDK", "$NANOSP_SDK", "$STAX_SDK"]

src/ui/address/address_ui_nbgl.c Outdated Show resolved Hide resolved
@tdejoigny-ledger
Copy link

and same as for Tron it seems that the swap tests are not running for Flex target.
cc: @fbeutin-ledger

@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1648_Port-Flex branch 3 times, most recently from f5f605e to f2fde56 Compare May 24, 2024 12:42
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@cedelavergne-ledger cedelavergne-ledger merged commit 6cbedc6 into develop May 27, 2024
118 checks passed
@cedelavergne-ledger cedelavergne-ledger deleted the cev/B2CA-1648_Port-Flex branch May 27, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants