Fix cx_hash_no_throw return value #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedelavergne-ledger
force-pushed
the
cev/fix_scan-build2
branch
2 times, most recently
from
70d66c9 to
bf1c4a4
Compare
cedelavergne-ledger
force-pushed
the
cev/fix_scan-build2
branch
from
bf1c4a4 to
eaa806c
Compare
cedelavergne-ledger
force-pushed
the
cev/fix_scan-build2
branch
from
eaa806c to
2427ecb
Compare
cedelavergne-ledger
force-pushed
the
cev/fix_scan-build2
branch
from
0d27acc to
326e29f
Compare
fbeutin-ledger
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
ledger-secure-sdkcommit "Check return value for cx_hash_no_throw", fix the error inscan-build.Adapt the unit-tests accordingly
Note: The failed workflow "Swap functionnal tests" also fails on develop
branch.