App update #42
Merged
App update #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
cedelavergne-ledger
force-pushed
the
app_update
branch
7 times, most recently
from
4c840e3 to
1fcc8a3
Compare
cedelavergne-ledger
force-pushed
the
app_update
branch
from
1fcc8a3 to
323f28a
Compare
cedelavergne-ledger
requested review from
agrojean-ledger,
fbeutin-ledger and
tdejoigny-ledger
cedelavergne-ledger
force-pushed
the
app_update
branch
from
323f28a to
23331d9
Compare
- Delete header file common with sdk - Rename few files to avoid name conflict with sdk
- Add utils module - Add generic navigate function - Fix get_public_key with correct returned length - Add get_public_key returned value check (with chain code) - Add get_public_key with confirmation - Add get_public_key new tests with 'accepted' and 'rejected' - Add get_public_key new screenshots - Add get_configuration test to check the returned version - Add sign_valid_tx returned signature check - Add sign_tx new tests with 'rejected' - Cleanup sign function
- This was in a previously approved but not merged PR (#23)
cedelavergne-ledger
force-pushed
the
app_update
branch
from
23331d9 to
48968dc
Compare
agrojean-ledger
approved these changes
Oct 2, 2023
| # XRP Wallet App for Ledger Nano S and Ledger Nano X | ||
| # XRP Wallet App for Ledger devices | ||
|
|
||
| [](https://github.com/LedgerHQ/app-flow/actions/workflows/guidelines_enforcer.yml) |
There was a problem hiding this comment.
Badges should point to /app-xrp/ instead of /app-flow/
There was a problem hiding this comment.
Can you open a PR to fix it ? I'll do it otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the repository:
Makefileto default Ledger standardglyphs, already present in SDKraggertestsutilsmodule with genericnavigatefunctionget_public_keychain_code)get_configurationtest to check the returned versionsign_valid_tx