forked from solana-labs/ledger-app-solana
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stax porting #59
Closed
Closed
Stax porting #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
fbeutin-ledger
force-pushed
the
fbe/stax_porting
branch
14 times, most recently
from
March 23, 2023 17:46
3f24a46
to
de72b36
Compare
fbeutin-ledger
changed the base branch from
wip/fbeutin/swap_rebase_post_refacto
to
fbe/separate_ui_from_parsing
March 23, 2023 17:49
fbeutin-ledger
force-pushed
the
fbe/stax_porting
branch
2 times, most recently
from
March 23, 2023 17:54
eee4eb8
to
d6d3f9d
Compare
fbeutin-ledger
force-pushed
the
fbe/separate_ui_from_parsing
branch
from
March 23, 2023 17:55
9554e1f
to
e4aa983
Compare
This was referenced Mar 23, 2023
Merged
fbeutin-ledger
force-pushed
the
fbe/separate_ui_from_parsing
branch
from
March 23, 2023 18:04
e4aa983
to
b0bdbf2
Compare
fbeutin-ledger
force-pushed
the
fbe/stax_porting
branch
from
March 23, 2023 18:04
d6d3f9d
to
96d7e9d
Compare
fbeutin-ledger
force-pushed
the
fbe/stax_porting
branch
4 times, most recently
from
March 30, 2023 13:15
bfa0e29
to
108be1e
Compare
fbeutin-ledger
force-pushed
the
fbe/separate_ui_from_parsing
branch
from
March 30, 2023 16:02
50f3704
to
361a2cf
Compare
fbeutin-ledger
force-pushed
the
fbe/stax_porting
branch
from
March 30, 2023 16:02
108be1e
to
49a16d1
Compare
fbeutin-ledger
force-pushed
the
fbe/separate_ui_from_parsing
branch
from
March 30, 2023 16:04
361a2cf
to
7027386
Compare
fbeutin-ledger
force-pushed
the
fbe/stax_porting
branch
2 times, most recently
from
March 30, 2023 17:15
42ae6d1
to
94ccd09
Compare
fbeutin-ledger
force-pushed
the
fbe/stax_porting
branch
from
April 11, 2023 14:21
94ccd09
to
6af939a
Compare
SonarCloud Quality Gate failed. |
fbeutin-ledger
force-pushed
the
fbe/separate_ui_from_parsing
branch
from
April 21, 2023 13:44
7027386
to
cb54087
Compare
fbeutin-ledger
force-pushed
the
fbe/separate_ui_from_parsing
branch
from
June 6, 2023 14:06
cb54087
to
4d90622
Compare
conclusion here #69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have finished ported the Solana application for our latest device Ledger Stax
My work is taking place on top of the swap modifications I made
#44
I have separated the new feature in three independant PRs:
Add more Ragger tests for automated non regression testing and Stax screen reproducability
Add more ragger tests #61
Extract the UI code from the logic handling code for the current graphical library BAGL
Separate UI from parsing before Stax porting #62
And finally the Stax porting itself for all screens
Stax porting #59