Use serde #34
Merged
Use serde #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrojean-ledger
force-pushed
the
use-serde
branch
from
98f2019 to
d9d3002
Compare
agrojean-ledger
force-pushed
the
use-serde
branch
from
d9d3002 to
fca7177
Compare
kingofpayne
force-pushed
the
use-serde
branch
from
6d71626 to
9e23213
Compare
kingofpayne
previously approved these changes
Nov 22, 2023
agrojean-ledger
commented
Nov 23, 2023
agrojean-ledger
commented
Nov 23, 2023
agrojean-ledger
commented
Nov 23, 2023
agrojean-ledger
commented
Nov 23, 2023
agrojean-ledger
commented
Nov 23, 2023
agrojean-ledger
commented
Nov 24, 2023
Better use of rust expression pattern matching.
agrojean-ledger
force-pushed
the
use-serde
branch
from
a3d8809 to
5ff6f1d
Compare
kingofpayne
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use serde + json for transaction deserialization instead of a custom implementation. Makes the app code simpler and encourages developers to reuse existing solutions.
Small improvements in APDU handling (for bad length error)