Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAPPS-1102 Add fee to swap transaction validation #24

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

joaoccmartins
Copy link
Collaborator

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.89%. Comparing base (02d07f3) to head (0c49c79).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #24   +/-   ##
========================================
  Coverage    49.89%   49.89%           
========================================
  Files            8        8           
  Lines          483      483           
  Branches       120      120           
========================================
  Hits           241      241           
  Misses         242      242           
Flag Coverage Δ
unittests 49.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaoccmartins
Copy link
Collaborator Author

@bboilot-ledger changes to the validation to support the fees, as request in the other PR.

Had to also update the Exchange app tests to validate that the fee was taken into account (PR here)
cc @fbeutin-ledger @may01

@joaoccmartins joaoccmartins force-pushed the swap/add-fee-to-validate branch 2 times, most recently from 776dc6f to bb0ffdb Compare February 26, 2025 16:36
bboilot-ledger
bboilot-ledger previously approved these changes Feb 27, 2025
@joaoccmartins joaoccmartins force-pushed the swap/add-fee-to-validate branch 3 times, most recently from 9673358 to c0edd73 Compare February 27, 2025 12:37
@joaoccmartins joaoccmartins force-pushed the swap/add-fee-to-validate branch from c0edd73 to 0c49c79 Compare February 27, 2025 12:41
@joaoccmartins joaoccmartins merged commit f687df9 into develop Feb 27, 2025
185 checks passed
@joaoccmartins joaoccmartins deleted the swap/add-fee-to-validate branch February 27, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants