New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check address #19

Draft

joaoccmartins wants to merge 3 commits into LedgerHQ:develop from LedgerHQ:swap/add_check_address

joaoccmartins commented Jan 15, 2025

Checklist

App update process has been followed
Target branch is develop
Application version has been bumped

joaoccmartins added 3 commits

January 8, 2025 17:40


          Added the swap_handle_check_addres. Added initial checks on parameters.

785f001


          Initial function dev.

d1e2b8b


          Fixing some functions and configs.

87862bf

github-advanced-security bot found potential problems

View reviewed changes

src/swap/handle_swap_sign_transaction.c

+              #include "globals.h"
+              bool swap_copy_transaction_parameters(create_transaction_parameters_t* params) {
+                  PRINTF("TODO: swap_copy_transaction_parameters\n");

Check failure

Code scanning / CodeQL

Missing return statement Error

Function swap_copy_transaction_parameters should return a value of type bool but does not return a value here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet