Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to disable the border on image as fog #74

Open
UranusBytes opened this issue Aug 31, 2022 · 5 comments
Open

Provide option to disable the border on image as fog #74

UranusBytes opened this issue Aug 31, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@UranusBytes
Copy link
Collaborator

When an image is used as fog layer, a border is draw to show what is visible. Provide an option to disable this border. The use case is that the fog layer is a map without labels or other items, but the fog layer is progressively removed to show the labels/whatever on the background.

@Derinzed
Copy link

Derinzed commented Sep 2, 2022

Thank you for this, sorry for not getting back to you quickly.

@UranusBytes UranusBytes added wontfix This will not be worked on and removed enhancement New feature or request labels Sep 3, 2022
@UranusBytes
Copy link
Collaborator Author

This effect is caused by the tint (Player Fog Color) applied to the canvas layer. If you set the Player Fog Settings Color to a value of #FFFFFF this doesn't actually set the tint to white, but removes the tint effect. https://pixijs.download/dev/docs/PIXI.Sprite.html#tint

Note that even with the tint set to #FFFFFF, any grids added to the map will still only be shown on the unmasked portion of the image, so if a grid line happens to be behind a masked area, players could still deduce that there was masked map content there.

Player Fog Color of #000000
image

Player Fog Color of #FFFFFF
image

@Derinzed
Copy link

Derinzed commented Sep 3, 2022

I seem to still end up with a white border when using #FFFFFF:

image

Settings:
image

is there another setting that I've configured improperly?

@UranusBytes
Copy link
Collaborator Author

No, you are correct. I was mistaken in the previous testing I'd done. I can confirm that setting to FFFFFF still shows as white. I had a code fix prototyped earlier. Let me resurrect it...

@UranusBytes UranusBytes reopened this Sep 3, 2022
@UranusBytes UranusBytes added enhancement New feature or request and removed wontfix This will not be worked on labels Sep 4, 2022
@UranusBytes
Copy link
Collaborator Author

Same as #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants