Update for fvtt10 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Varriount
reviewed
Mar 28, 2023
.github/workflows/release.yml
Outdated
Comment on lines
75
to
82
| #- name: FoundryVTT AutoPublish | ||
| # uses: Varriount/[email protected] | ||
| # with: | ||
| # username: ${{ secrets.FOUNDRY_ADMIN_USER }} | ||
| # password: ${{ secrets.FOUNDRY_ADMIN_PW }} | ||
| # module-id: 288 | ||
| # manifest-url: https://github.com/${{ github.repository }}/releases/download/${{ env.RELEASE_VERSION }}/module.json | ||
| # manifest-file: ./src/module.json |
Varriount
reviewed
Mar 28, 2023
src/init.ts
Outdated
There was a problem hiding this comment.
Please use 2 spaces for indentation, rather than tabs.
There was a problem hiding this comment.
applied a new prettier, if you need some other modification let me know it. Here the prettier configuration https://github.com/p4535992/foundryvtt-forien-unidentified-items/blob/master/.prettierrc.js
|
@Varriount Just a reminder for this |
Varriount
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BREAKING CHANGES]
Should fix these issues: