Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the system limitation and check the generic solution #32

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

p4535992
Copy link

@p4535992 p4535992 commented Sep 6, 2022

Then it is clear that @Forien was a dragon with this code because even without the item properties the basic functionalities of the module work with the "generic" case. So to fix the problem No longer works on PF1E (and also for backward compatibility) i removed the tag system from the module.json.

This was a miss from my side sorry @Varriount .

All the other bugs remain to be fixed ... and the update to fvtt10...

P.S. @Varriount i didn't apply the new prettier configuration just to point out that I haven't touched any of the code other than removing some commented code, If you like, you can apply it before the release

@Varriount
Copy link

Feel free to make the Prettier PR at any time - since it doesn't actually affect functionality, it doesn't matter whether it's included in a release.

@Varriount Varriount merged commit e8ddb7f into League-of-Foundry-Developers:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants