Fix and improve crud test #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrigline
reviewed
Mar 20, 2022
Foundry doesn't like .update() on synthetic actors
|
I removed synthetic option as I discovered it wasn't used correctly, and after I fixed it, I also realized Foundry explodes on .update() calls to such. So even if the idea is great (IMO), Foundry doesn't support it (https://gitlab.com/foundrynet/foundryvtt/-/issues/6824). |
akrigline
reviewed
Mar 21, 2022
akrigline
reviewed
Mar 21, 2022
akrigline
requested changes
Mar 21, 2022
akrigline
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements actor type selection
and synthetic actor toggle. Also small improvements to related code thrown in.Fixes #39