Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actor CRUD test unnecessarily includes database operations in it #38

Open
mkahvi opened this issue Mar 20, 2022 · 4 comments
Open

Actor CRUD test unnecessarily includes database operations in it #38

mkahvi opened this issue Mar 20, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@mkahvi
Copy link
Contributor

mkahvi commented Mar 20, 2022

Currently the actor CRUD test creates database backed actors. This adds unnecessary variance in the statistics via database and network transmission latencies.

It should instead create synthetic actor with Actor.create(data, {temporary:true}) so it measures only the actual processing time instead of also network and server latency.

@mkahvi mkahvi added the bug Something isn't working label Mar 20, 2022
@akrigline
Copy link
Member

The Network and Server latency are useful indications of server health in some cases. They were interesting metrics when we first started exploring this concept.

It might be worth making an additional temporary test, but I would not remove the existing full blown test.

@mkahvi
Copy link
Contributor Author

mkahvi commented Mar 20, 2022

It might be worth making an additional temporary test, but I would not remove the existing full blown test.

Way ahead of you, I think xD

@akrigline
Copy link
Member

that you are! big thanks!

@mkahvi
Copy link
Contributor Author

mkahvi commented Mar 20, 2022

Alright, the PR was a bust due to upstream limitations: https://gitlab.com/foundrynet/foundryvtt/-/issues/6824

@akrigline akrigline added enhancement New feature or request and removed bug Something isn't working labels Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants