Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update common/data/data.mjs to 331 #2835

Merged
merged 2 commits into from
Oct 24, 2024
Merged

feat: update common/data/data.mjs to 331 #2835

merged 2 commits into from
Oct 24, 2024

Conversation

kmoschcau
Copy link
Collaborator

Closes #2809

@kmoschcau kmoschcau requested a review from a team as a code owner October 24, 2024 07:07
LukeAbby
LukeAbby approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@LukeAbby LukeAbby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR itself looks fine, just some questions about the comments.

Thanks for going and doing these updates!

src/foundry/common/data/data.d.mts Outdated Show resolved Hide resolved
src/foundry/common/data/data.d.mts Outdated Show resolved Hide resolved
src/foundry/common/documents/token.d.mts Outdated Show resolved Hide resolved
@LukeAbby LukeAbby merged commit 0a48df7 into v12/main Oct 24, 2024
2 of 6 checks passed
@LukeAbby LukeAbby deleted the feature/update-data-data-to-331 branch October 24, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeAbby LukeAbby LukeAbby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmoschcau @LukeAbby