Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] build ast and with debug function #38

Merged
merged 42 commits into from
Dec 23, 2023
Merged

[FEAT] build ast and with debug function #38

merged 42 commits into from
Dec 23, 2023

Conversation

LeaYeh
Copy link
Owner

@LeaYeh LeaYeh commented Dec 23, 2023 •
edited
Loading

Resolve #35

@itislu itislu linked an issue Dec 23, 2023 that may be closed by this pull request
[REFACTOR] Let's remove the ft_stkpeektop function to make possible segfaults more apparent in the code #22
Closed
@itislu
Copy link
Collaborator

itislu commented Dec 23, 2023

@LeaYeh We should remove Issue #35 from this PR because it is about removing the function from libft.
Issue #22 is about the refactoring in the parser.

itislu and others added 28 commits December 23, 2023 21:25
@itislu @LeaYeh
style: Rename all instances of 'data' to 'token_data'
10b2b6b
@itislu @LeaYeh
refactor: Set the token type after the token_list has been fully created
c28ffd5
@itislu @LeaYeh
fix: Set T_ASSIGNMENT_WORD token types correctly
e88a190 
Implementation:
After the token_list has been created and the token types have been set,
there is now a second stage that goes through the token_list again and
changes any mislabeled T_ASSIGNMENT_WORD token types to T_WORD.
@itislu @LeaYeh
fix: Fix potential memory leaks and make use of token_utils functions
4ea6d7b
@itislu @LeaYeh
style: Remove unneeded header files + norminette
ce6ab95
@itislu @LeaYeh
fix: Fix wrong return type
688a7cc
@itislu @LeaYeh
build: Massively improve build speed by letting make use more CPU cores
999ed3a
@itislu @LeaYeh
build: Compile the object files into a separate directory
cd584a4
@itislu @LeaYeh
build: Add dependency file creation to Makefile
ec7bb82 
These additions tell the compiler to separate the compile process into 3 stages:
1. Pre-processing:
Creates .d files which keep track of all header file dependencies.
2. Compiling:
Compiles the source files into object files.
3. Linking:
Links the object files into an executable.

Now, whenever something in a header file changes, all source files that include this header file will recompile, even if nothing in the source files themselves changed.
@itislu @LeaYeh
build: Add print rule to Makefile for Makefile debugging
11b829c
@itislu @LeaYeh
build: Let the project recompile when the Makefile changes
af242f2
@itislu @LeaYeh
build: Rename single-letter directory variables
ff0b03e
@itislu @LeaYeh
build: Automatically include all libraries from the libraries directo…
d098d4d 
…ry in the compilation
@itislu @LeaYeh
build: Make main project recompile when library files change
fb32182 
When something in a library changes, the main project should be recompiled.

But there's a bug:
Because of the -j MAKEFLAG, multiple make jobs get executed at the same time. This means the library files might get checked for changes before the library actually compiles any changes.
In that case, make has to be run again to include the updated library into the main executable.
@itislu @LeaYeh
build: Call to nproc is unnecessary, -j also means use all resources
b70e43d
@itislu @LeaYeh
build: Temporary fix to ensure main executable gets recompiled when l…
3ec1748 
…ibrary files change
@itislu @LeaYeh
build: Don't print out certain stages of the Make process
6e94005
@itislu @LeaYeh
build: Fix error messages from 'find' function if dir not exist
44e3f18
@itislu @LeaYeh
build: Check which version of Make is available to adjust multithread…
fd49c90 
…ing features
@itislu @LeaYeh
build: Silence default print-outs, replace with custom messages
1d3622b 
The -s flag silences everything coming from Make.
Therefore no other steps to silence printouts are needed anymore and have been removed.

What kind of messages should get printed out is determined by the exit codes of new instances of Make and AND and OR operations.
This message handling rule is now the default for the 'all' goal and gets checked everytime Make is run.

The actual build prerequisites have been moved to a new goal, called 'build'.
@itislu @LeaYeh
build: Improve readability and layout of Makefile
3269be7
@LeaYeh
refact: Change the basic data type
732025e
@LeaYeh
refact: Change the data type in parser module
12d37ab
@itislu @LeaYeh
lib: Make ft_lst functions behave exactly the same as ft_stk functions
1d673fa 
Now the ft_lstclear and ft_lstdelone functions still free the node even when the function pointer argument is NULL. This really is more useful.

And the ft_lstpop function now also sets the next ptr for the popped node to NULL.
@itislu @LeaYeh
lib: Add ft_lstswap_head function to libft
ecacee9
@itislu @LeaYeh
lib: Change ft_lstadd functions to add full lists to another list, no…
61ddaf7 
…t just a single node
@itislu @LeaYeh
style: Standardize ft_lst function coding style and improve readability
954b92c
@itislu @LeaYeh
doc: Add @note highlighting feature to libft documentation
4f2ef50
itislu and others added 13 commits December 23, 2023 21:25
@itislu @LeaYeh
refactor: Replace ft_stk functions with ft_lst functions
ce9d01e
@itislu @LeaYeh
lib: Remove ft_stk functions from libft
8c48b8a
@itislu @LeaYeh
fix: Prevent segfaults in ft_strmatches_any
25d3951 
If given a NULL, now it will search for another NULL in the other given strings.
Also no segfault anymore when any of the given strings is NULL.
@itislu @LeaYeh
doc: Add documentation to the rest of the libft functions that can se…
2f1c50b 
…gfault
@itislu @LeaYeh
style: Rename a tmp variable in parser to be more descriptive
945cf59
@itislu @LeaYeh
style: Rename ft_lstpop functions to ft_lstpop_front
c572696
@LeaYeh
fix: Fix merge confilict
ceb3a20
@LeaYeh
feat: Implement the AST tree as output of the parser
3e18180
@LeaYeh
fix: Wrong order when popped the related nodes in reduction
f0a9e49
@LeaYeh
feat: Add debug function to print ast with BFS
04ec7c1
@LeaYeh
fix: Fix the typo of the function name
181c467
@LeaYeh
fix: Align the function name with the libft
88d8ee0
@LeaYeh
fix: Fix memory leak which happend during rebase
4688b0b
@itislu itislu merged commit 034f7d9 into main Dec 23, 2023
1 check passed
@itislu itislu deleted the feat-build-ast branch December 23, 2023 21:18
@itislu itislu self-assigned this Dec 23, 2023
@itislu itislu added the feature New feature of the project label Dec 23, 2023
@itislu itislu added this to the Parser milestone Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itislu itislu itislu approved these changes

Assignees

@itislu itislu

Labels
feature New feature of the project
Projects
None yet
Milestone
Parser
2 participants
@LeaYeh @itislu