Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIB] Refactor the data type of stack to t_lst #31

Merged
merged 13 commits into from
Dec 23, 2023
Merged

[LIB] Refactor the data type of stack to t_lst #31

merged 13 commits into from
Dec 23, 2023

Conversation

LeaYeh
Copy link
Owner

@LeaYeh LeaYeh commented Dec 22, 2023

No description provided.

@LeaYeh LeaYeh added the enhancement Enhancement of an existing feature label Dec 22, 2023
@itislu
Copy link
Collaborator

itislu commented Dec 23, 2023

Will review tomorrow!

@itislu itislu self-assigned this Dec 23, 2023
@itislu itislu linked an issue Dec 23, 2023 that may be closed by this pull request
[LIB] Change libft stack functions from using a t_stk struct to using a t_lst struct #26
Closed
@itislu itislu changed the title [FEAT] Refactor the data type of stack [LIB] Refactor the data type of stack to t_lst Dec 23, 2023
@itislu
Copy link
Collaborator

itislu commented Dec 23, 2023 •
edited
Loading

Waiting for PR #36 merge into this branch.
Then we can merge into main if you agree with all the changes that I made to this branch.

itislu added 11 commits December 23, 2023 20:48
@itislu @LeaYeh
lib: Make ft_lst functions behave exactly the same as ft_stk functions
e7e3f43 
Now the ft_lstclear and ft_lstdelone functions still free the node even when the function pointer argument is NULL. This really is more useful.

And the ft_lstpop function now also sets the next ptr for the popped node to NULL.
@itislu @LeaYeh
lib: Add ft_lstswap_head function to libft
9a7df14
@itislu @LeaYeh
lib: Change ft_lstadd functions to add full lists to another list, no…
a295837 
…t just a single node
@itislu @LeaYeh
style: Standardize ft_lst function coding style and improve readability
ddd7ccc
@itislu @LeaYeh
doc: Add @note highlighting feature to libft documentation
64d055f
@itislu @LeaYeh
refactor: Replace ft_stk functions with ft_lst functions
b8195b5
@itislu @LeaYeh
lib: Remove ft_stk functions from libft
3109c80
@itislu @LeaYeh
fix: Prevent segfaults in ft_strmatches_any
89edf98 
If given a NULL, now it will search for another NULL in the other given strings.
Also no segfault anymore when any of the given strings is NULL.
@itislu @LeaYeh
doc: Add documentation to the rest of the libft functions that can se…
b26337c 
…gfault
@itislu @LeaYeh
style: Rename a tmp variable in parser to be more descriptive
4c3698a
@itislu
style: Rename ft_lstpop functions to ft_lstpop_front
7a706c4
@LeaYeh LeaYeh merged commit 1d6e958 into main Dec 23, 2023
1 check passed
@LeaYeh LeaYeh deleted the feat-refact-stack branch December 23, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itislu itislu itislu approved these changes

Assignees

@itislu itislu

Labels
enhancement Enhancement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LIB] Change libft stack functions from using a t_stk struct to using a t_lst struct
2 participants
@LeaYeh @itislu