🐛 fix(tests): notification bulk create in fixture

.pre-commit-config.yaml

@@ -85,14 +85,14 @@ repos:
 
   - repo: local
     hooks:
-#      - id: pytest
-#        name: Pytest
-#        entry: poetry run pytest -v
-#        language: system
-#        types: [ python ]
-#        stages: [ commit ]
-#        pass_filenames: false
-#        always_run: true
+      - id: pytest
+        name: Pytest
+        entry: poetry run pytest -v
+        language: system
+        types: [ python ]
+        stages: [ commit ]
+        pass_filenames: false
+        always_run: true
 
       - id: pylint
         name: pylint

django_notification/api/views/activity.py

@@ -11,13 +11,12 @@
 from rest_framework.serializers import Serializer
 from rest_framework.viewsets import GenericViewSet
 
-from django_notification.api.serializers.notification import \
-    NotificationSerializer
-from django_notification.api.serializers.simple_notification import \
-    SimpleNotificationSerializer
+from django_notification.api.serializers.notification import NotificationSerializer
+from django_notification.api.serializers.simple_notification import (
+    SimpleNotificationSerializer,
+)
 from django_notification.decorators.action import conditional_action
-from django_notification.mixins import (ConfigurableAttrsMixin,
-                                        DisableMethodsMixin)
+from django_notification.mixins import ConfigurableAttrsMixin, DisableMethodsMixin
 from django_notification.models.notification import Notification
 from django_notification.settings.conf import config
 

django_notification/api/views/notification.py

@@ -11,12 +11,11 @@
 from rest_framework.serializers import Serializer
 from rest_framework.viewsets import GenericViewSet
 
-from django_notification.api.serializers.notification import \
-    NotificationSerializer
-from django_notification.api.serializers.simple_notification import \
-    SimpleNotificationSerializer
-from django_notification.mixins import (ConfigurableAttrsMixin,
-                                        DisableMethodsMixin)
+from django_notification.api.serializers.notification import NotificationSerializer
+from django_notification.api.serializers.simple_notification import (
+    SimpleNotificationSerializer,
+)
+from django_notification.mixins import ConfigurableAttrsMixin, DisableMethodsMixin
 from django_notification.models.notification import Notification
 from django_notification.settings.conf import config
 

django_notification/tests/api/__init__.py

@@ -1,3 +1,3 @@
 from . import views
 from . import paginations
-from . import throttlings
+from . import throttlings

django_notification/tests/api/serializers/test_simple_notification_serializer.py

@@ -6,7 +6,9 @@
 from django_notification.api.serializers.simple_notification import (
     SimpleNotificationSerializer,
 )
-from django_notification.utils.serialization.field_filters import filter_non_empty_fields
+from django_notification.utils.serialization.field_filters import (
+    filter_non_empty_fields,
+)
 from django_notification.utils.serialization.notif_title_generator import generate_title
 from pytest import mark
 from django_notification.tests.constants import PYTHON_VERSION, PYTHON_VERSION_REASON

django_notification/tests/api/throttlings/test_role_base_throttle.py

@@ -8,7 +8,9 @@
 from rest_framework.response import Response
 from django.core.cache import cache
 
-from django_notification.api.throttlings.role_base_throttle import RoleBasedUserRateThrottle
+from django_notification.api.throttlings.role_base_throttle import (
+    RoleBasedUserRateThrottle,
+)
 from django_notification.settings.conf import config
 from django_notification.tests.constants import PYTHON_VERSION, PYTHON_VERSION_REASON
 

django_notification/tests/api/views/test_activity.py

@@ -35,7 +35,9 @@ def setup_method(self) -> None:
         """
         self.client = APIClient()
 
-    def test_get_queryset_for_staff(self, admin_user: User, notification: Notification) -> None:
+    def test_get_queryset_for_staff(
+        self, admin_user: User, notification: Notification
+    ) -> None:
         """
         Test that staff users can retrieve all seen notifications.
 
@@ -58,7 +60,9 @@ def test_get_queryset_for_staff(self, admin_user: User, notification: Notificati
             == Notification.queryset.seen(seen_by=admin_user).count()
         )
 
-    def test_get_queryset_for_non_staff(self, user: User, notification: Notification) -> None:
+    def test_get_queryset_for_non_staff(
+        self, user: User, notification: Notification
+    ) -> None:
         """
         Test that non-staff users retrieve notifications based on their group memberships.
 
@@ -100,7 +104,9 @@ def test_list_method_disabled(self, user: User) -> None:
         assert response.status_code == 405  # Method Not Allowed
 
     @patch.object(config, "api_allow_retrieve", False)
-    def test_retrieve_method_disabled(self, user: User, notification: Notification) -> None:
+    def test_retrieve_method_disabled(
+        self, user: User, notification: Notification
+    ) -> None:
         """
         Test that the retrieve method is disabled when `api_allow_retrieve` is False in the config.
 
@@ -119,7 +125,9 @@ def test_retrieve_method_disabled(self, user: User, notification: Notification)
         assert response.status_code == 405  # Method Not Allowed
 
     @patch.object(config, "include_serializer_full_details", True)
-    def test_full_details_serializer_used(self, user: User, notification: Notification) -> None:
+    def test_full_details_serializer_used(
+        self, user: User, notification: Notification
+    ) -> None:
         """
         Test that the full details serializer is used when `include_serializer_full_details` is True.
 
@@ -169,7 +177,9 @@ def test_clear_activities(self, user: User, notification: Notification) -> None:
             Notification.queryset.sent().count() == DeletedNotification.objects.count()
         )
 
-    def test_clear_notification(self, admin_user: User, notification: Notification) -> None:
+    def test_clear_notification(
+        self, admin_user: User, notification: Notification
+    ) -> None:
         """
         Test the clear_notification action to soft delete a specific notification.
 
@@ -192,7 +202,9 @@ def test_clear_notification(self, admin_user: User, notification: Notification)
         assert DeletedNotification.objects.filter(notification=notification).exists()
 
     @patch.object(config, "include_hard_delete", True)
-    def test_delete_activities(self, admin_user: User, notification: Notification) -> None:
+    def test_delete_activities(
+        self, admin_user: User, notification: Notification
+    ) -> None:
         """
         Test the delete_activities action to hard delete all notifications.
 
@@ -218,7 +230,9 @@ def test_delete_activities(self, admin_user: User, notification: Notification) -
         assert not Notification.queryset.all_notifications()
 
     @patch.object(config, "include_hard_delete", True)
-    def test_delete_notification(self, admin_user: User, notification: Notification) -> None:
+    def test_delete_notification(
+        self, admin_user: User, notification: Notification
+    ) -> None:
         """
         Test the delete_notification action to hard delete a specific notification.
 

django_notification/tests/api/views/test_notification.py

@@ -36,7 +36,9 @@ def setup_method(self) -> None:
         """
         self.client = APIClient()
 
-    def test_get_queryset_for_staff(self, admin_user: Type[User], notification: Notification) -> None:
+    def test_get_queryset_for_staff(
+        self, admin_user: Type[User], notification: Notification
+    ) -> None:
         """
         Test that staff users retrieve all unseen notifications.
 
@@ -62,7 +64,9 @@ def test_get_queryset_for_staff(self, admin_user: Type[User], notification: Noti
             == Notification.queryset.unseen(unseen_by=admin_user).count()
         )
 
-    def test_get_queryset_for_non_staff(self, user: Type[User], notification: Notification) -> None:
+    def test_get_queryset_for_non_staff(
+        self, user: Type[User], notification: Notification
+    ) -> None:
         """
         Test that non-staff users retrieve unseen notifications based on their group memberships.
 
@@ -85,7 +89,9 @@ def test_get_queryset_for_non_staff(self, user: Type[User], notification: Notifi
             == Notification.queryset.unseen(unseen_by=user).count()
         )
 
-    def test_retrieve_notification(self, user: Type[User], notification: Notification) -> None:
+    def test_retrieve_notification(
+        self, user: Type[User], notification: Notification
+    ) -> None:
         """
         Test the retrieve functionality to get a specific notification and mark it as seen.
 
@@ -106,7 +112,9 @@ def test_retrieve_notification(self, user: Type[User], notification: Notificatio
         assert response.status_code == 200
         assert Notification.queryset.seen(seen_by=user).exists()
 
-    def test_mark_all_as_seen(self, user: Type[User], notification: Notification) -> None:
+    def test_mark_all_as_seen(
+        self, user: Type[User], notification: Notification
+    ) -> None:
         """
         Test the mark_all_as_seen action to mark all notifications as seen for the user.
 
@@ -145,7 +153,9 @@ def test_list_method_disabled(self, user: Type[User]) -> None:
         assert response.status_code == 405  # Method Not Allowed
 
     @patch.object(config, "api_allow_retrieve", False)
-    def test_retrieve_method_disabled(self, user: Type[User], notification: Notification) -> None:
+    def test_retrieve_method_disabled(
+        self, user: Type[User], notification: Notification
+    ) -> None:
         """
         Test that the retrieve method is disabled when `api_allow_retrieve` is False in the config.
 
@@ -165,7 +175,9 @@ def test_retrieve_method_disabled(self, user: Type[User], notification: Notifica
         assert response.status_code == 405  # Method Not Allowed
 
     @patch.object(config, "include_serializer_full_details", True)
-    def test_full_details_serializer_used(self, user: Type[User], notification: Notification) -> None:
+    def test_full_details_serializer_used(
+        self, user: Type[User], notification: Notification
+    ) -> None:
         """
         Test that the full details serializer is used when `include_serializer_full_details` is True in the config.
 

django_notification/tests/conftest.py

@@ -14,5 +14,5 @@
     notification_recipient,
     notification_seen,
     deleted_notification,
-    admin_user
+    admin_user,
 )

django_notification/tests/fixtures/notification.py

@@ -146,7 +146,9 @@ def notifications(db, user: User, qs_user: User, qs_group: Group) -> List[Notifi
             timestamp=now(),
         ),
     ]
-    notifications = Notification.objects.bulk_create(notifications)
+    for notification in notifications:
+        notification.save()
+
     notifications[0].recipient.add(qs_user)
     notifications[1].recipient.add(qs_user)
     notifications[2].recipient.add(qs_user)

django_notification/tests/models/test_deleted_notification.py

@@ -36,7 +36,9 @@ def test_string_representation(
         )
         assert str(deleted_notification) == expected_str
 
-    def test_unique_together_constraint(self, notification: Notification, user: User) -> None:
+    def test_unique_together_constraint(
+        self, notification: Notification, user: User
+    ) -> None:
         """
         Test that the combination of user and notification is unique.
 
@@ -56,7 +58,9 @@ def test_unique_together_constraint(self, notification: Notification, user: User
                 notification=notification, user=user, deleted_at=now()
             )
 
-    def test_save_method_with_valid_user(self, notification: Notification, user: User) -> None:
+    def test_save_method_with_valid_user(
+        self, notification: Notification, user: User
+    ) -> None:
         """
         Test the save method when the user is a recipient or group member of the notification.
 
@@ -78,7 +82,9 @@ def test_save_method_with_valid_user(self, notification: Notification, user: Use
             notification=notification, user=user
         ).exists()
 
-    def test_save_method_with_invalid_user(self, notification: Notification, another_user: User) -> None:
+    def test_save_method_with_invalid_user(
+        self, notification: Notification, another_user: User
+    ) -> None:
         """
         Test that a `PermissionError` is raised when the user is not a recipient or group member.
 
@@ -96,7 +102,9 @@ def test_save_method_with_invalid_user(self, notification: Notification, another
             )
             deleted_notification.save()
 
-    def test_save_method_for_staff_user(self, notification: Notification, user: User) -> None:
+    def test_save_method_for_staff_user(
+        self, notification: Notification, user: User
+    ) -> None:
         """
         Test that a staff user can save `DeletedNotification` even if they are not a recipient or group member.
 

django_notification/tests/models/test_notification.py

@@ -89,7 +89,9 @@ def test_title_generator_with_only_target(
 
         assert title == f"{user} liked {user}"
 
-    def test_title_generator_with_no_target_or_action_object(self, notification: Notification, user: User) -> None:
+    def test_title_generator_with_no_target_or_action_object(
+        self, notification: Notification, user: User
+    ) -> None:
         """
         Test the title generator when neither target nor action object are present.
 
@@ -113,7 +115,9 @@ def test_mark_as_seen(self, notification: Notification, user: User) -> None:
 
         assert notification.seen_by.filter(id=user.id).exists()
 
-    def test_mark_as_seen_with_group(self, notification: Notification, user: User, group: Group) -> None:
+    def test_mark_as_seen_with_group(
+        self, notification: Notification, user: User, group: Group
+    ) -> None:
         """
         Test the `mark_as_seen` method when the user belongs to a group that is a recipient.
 
@@ -149,7 +153,9 @@ def test_notification_str_representation(self, notification: Notification) -> No
         expected_str = f"{notification.description} now"
         assert str(notification) == expected_str
 
-    def test_add_recipients_to_notification(self, notification: Notification, user: User) -> None:
+    def test_add_recipients_to_notification(
+        self, notification: Notification, user: User
+    ) -> None:
         """
         Test adding recipients to the notification.
 
@@ -160,7 +166,9 @@ def test_add_recipients_to_notification(self, notification: Notification, user:
         notification.recipient.add(user)
         assert notification.recipient.filter(id=user.id).exists()
 
-    def test_add_groups_to_notification(self, notification: Notification, group: Group) -> None:
+    def test_add_groups_to_notification(
+        self, notification: Notification, group: Group
+    ) -> None:
         """
         Test adding groups to the notification.
 

django_notification/tests/repository/test_queryset.py

@@ -18,6 +18,7 @@ class TestNotificationQuerySet:
     """
     Test suite for the `NotificationQuerySet`.
     """
+
     def test_all_notifications_with_recipients(
         self, notifications: List[Notification], qs_user: List[User]
     ) -> None:

django_notification/tests/urls.py

@@ -4,4 +4,4 @@
 urlpatterns = [
     path("admin/", admin.site.urls),
     path("notification/", include("django_notification.api.routers.notification")),
-]
+]