Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate from circleci to github actions #20

Merged
merged 12 commits into from
Jan 28, 2025

Conversation

samlaf
Copy link
Collaborator

@samlaf samlaf commented Jan 27, 2025

Closes DAINT-257

Summary

This PR gets rid of circleci and adds a simple github action to test golang code for parts of code that we plan to change (op-batcher, op-node, e2e altda tests)

Context

Op's circle config is checking a LOT of things. Don't think we need to be checking everything that they are already checking. Main 3 things are:

  1. test contracts
  2. test golang offchain code
  3. publish docker images

For each:

  1. Until we modify the contracts (possibly never), don't think we need to test their contract code again
  2. We do need to test golang code, but only for the parts that we are planning to change (op-batcher, op-node, e2e altda tests)
  3. Not sure we need to publish docker images given that our fork is probably going to be used downstream by other repo teams that will probably publish their own images. Might need to publish images anyways to run kurtosis tests, but will add that when needed

@samlaf samlaf merged commit 7c8bd46 into eigenda-develop Jan 28, 2025
6 checks passed
@samlaf samlaf deleted the ci--add-test-golang-workflow branch January 28, 2025 16:30
samlaf added a commit that referenced this pull request Feb 11, 2025
* ci: add test-golang workflow

* ci: delete circleci yml file

This was used by op, we are moving to using github actions for our fork

* ci: fix linter by using golangci-lint action

* ci: use golangci-lint v1.61 to match mise.toml requirement

* ci: use mise in ci to install correct versions of dependencies

* ci: remove setup-go step because go already installed by mise in previous step

* ci: build contracts that are needed for op-e2e tests

* ci: use caching for forge artifacts

* ci: remove slow op-program build

don't think we are using it... testing

* ci: make go-lint job run in parallel, and update version to try to fix errors

* ci: add go modules caching to speed up workflow

* ci: add explicit go mod download
samlaf added a commit that referenced this pull request Feb 11, 2025
* ci: add test-golang workflow

* ci: delete circleci yml file

This was used by op, we are moving to using github actions for our fork

* ci: fix linter by using golangci-lint action

* ci: use golangci-lint v1.61 to match mise.toml requirement

* ci: use mise in ci to install correct versions of dependencies

* ci: remove setup-go step because go already installed by mise in previous step

* ci: build contracts that are needed for op-e2e tests

* ci: use caching for forge artifacts

* ci: remove slow op-program build

don't think we are using it... testing

* ci: make go-lint job run in parallel, and update version to try to fix errors

* ci: add go modules caching to speed up workflow

* ci: add explicit go mod download
samlaf added a commit that referenced this pull request Feb 11, 2025
* ci: add test-golang workflow

* ci: delete circleci yml file

This was used by op, we are moving to using github actions for our fork

* ci: fix linter by using golangci-lint action

* ci: use golangci-lint v1.61 to match mise.toml requirement

* ci: use mise in ci to install correct versions of dependencies

* ci: remove setup-go step because go already installed by mise in previous step

* ci: build contracts that are needed for op-e2e tests

* ci: use caching for forge artifacts

* ci: remove slow op-program build

don't think we are using it... testing

* ci: make go-lint job run in parallel, and update version to try to fix errors

* ci: add go modules caching to speed up workflow

* ci: add explicit go mod download
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants