Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging for batch header hash for batcher-node #545

Merged
merged 8 commits into from
May 8, 2024

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented May 6, 2024

Why are these changes needed?

To make it easier to correlate batcher-node communication on a per batch basis

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested review from shrimalmadhur and ian-shim May 6, 2024 17:43
Copy link
Contributor

@ian-shim ian-shim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion but this will result in a lot of extra lines of logs.
What do you think about passing the batch header hash in the signer message and logging it as part of logs here and here?

@@ -79,13 +83,15 @@ func (c *dispatcher) sendAllChunks(ctx context.Context, state *core.IndexedOpera
Signature: nil,
Operator: id,
}
c.logger.Warn("Failed to send chunks to operator", "batchHeaderHash", batchHeaderHash, "operator", op.Socket, "err", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also log operator IDs here and below?

@jianoaix
Copy link
Contributor Author

jianoaix commented May 8, 2024

here

Sounds good to me

@jianoaix
Copy link
Contributor Author

jianoaix commented May 8, 2024

Tested:

2024-05-08 13:22:02.220 | {"time":"2024-05-08T20:22:02.220421429Z","level":"WARN","source":{"function":"github.com/Layr-Labs/eigenda/core.(*StdSignatureAggregator).AggregateSignatures","file":"/app/core/aggregation.go","line":131},"msg":"error returned from messageChan","component":"SignatureAggregator","operatorID":"39638352822b2eecf33f2ea0e6893a576edbcc202b4925c3ab2875677945bf58","operatorAddress":"0xad9770d6b5514724c7b766f087bea8a784038cbe","socket":"18.208.146.49:32007;32008","batchHeaderHash":[147,252,95,99,206,177,111,125,109,84,0,119,245,234,89,206,143,59,28,166,14,208,146,106,212,88,205,139,38,154,149,48],"err":"rpc error: code = DeadlineExceeded desc = context deadline exceeded"}

@jianoaix jianoaix merged commit 83ef8bd into Layr-Labs:master May 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants