fix(CI): Update codesql scan to properly install contract deps #1265
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anupsv
reviewed
Feb 12, 2025
| @@ -41,6 +41,22 @@ jobs: | |||
| - name: Install Foundry | |||
| uses: foundry-rs/foundry-toolchain@v1 | |||
|
|
|||
| - name: Set Node.js 16.x | |||
| uses: actions/setup-node@v3 | |||
There was a problem hiding this comment.
For this, can u use setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a
anupsv
reviewed
Feb 12, 2025
| @@ -41,6 +41,22 @@ jobs: | |||
| - name: Install Foundry | |||
| uses: foundry-rs/foundry-toolchain@v1 | |||
|
|
|||
| - name: Set Node.js 16.x | |||
There was a problem hiding this comment.
I think we need node 18 ? or at least thats what i've been using.
anupsv
reviewed
Feb 12, 2025
| node-version: 16.x | ||
|
|
||
| - name: Run install | ||
| uses: borales/actions-yarn@v4 |
There was a problem hiding this comment.
actions-yarn@3766bb1335b98fb13c60eaf358fe20811b730a88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Checks