Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only override private BLS key in test mode if TestPrivateBlsFlag is defined #1244

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

pschork
Copy link
Contributor

@pschork pschork commented Feb 7, 2025

Only override private BLS key in test mode if TestPrivateBlsFlag is defined

Previously enabling test mode required TestPrivateBlsFlag to be set or would halt node with

pp-eigenda-native-node  | 2025/02/07 20:45:40 application failed: failed to create BLS signer: Element.SetString failed -> can't parse number into a big.Int

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@pschork pschork requested a review from jianoaix February 7, 2025 22:15
@pschork pschork merged commit ecd8171 into master Feb 7, 2025
9 checks passed
@pschork pschork deleted the pschork/test_mode_fix branch February 7, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants