Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused NumConnectionsToNodesFlag #1239

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Remove unused NumConnectionsToNodesFlag #1239

merged 1 commit into from
Feb 7, 2025

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Feb 7, 2025

Why are these changes needed?

Removing an unused flag from controller

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim requested a review from cody-littley February 7, 2025 17:43
@ian-shim ian-shim marked this pull request as ready for review February 7, 2025 18:19
@ian-shim ian-shim requested a review from dmanc February 7, 2025 18:20
@ian-shim ian-shim merged commit 0b31cb6 into Layr-Labs:master Feb 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanc dmanc dmanc approved these changes

@cody-littley cody-littley Awaiting requested review from cody-littley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-shim @dmanc