Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contracts): Add storage mapping checker #1238

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ethenotethan
Copy link
Contributor

@ethenotethan ethenotethan commented Feb 7, 2025

Why are these changes needed?

This is to ensure that we're loudly aware of when storage values dramatically change on our contracts (e.g, accidental overrides/conficts). This allows us to keep an up-to-date view of the latest storage layouts. When changes are made the CI will fail to give indication that changes must be assessed.

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant