Operator signing computing #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanc
approved these changes
Feb 3, 2025
| } | ||
| } | ||
|
|
||
| startTime := endTime.Add(-time.Duration(interval) * time.Second) |
There was a problem hiding this comment.
Should we add to the documentation that the API can only compute the signing info within the 14 day period (maxBlobAge)?
There was a problem hiding this comment.
It's a system wide constraint (no data is guaranteed after 14 days), not anything special
There was a problem hiding this comment.
Just want to make sure it's clear to the consumer of the Data API that they shouldn't expect to be able to query beyond the 14 days. Some may be interested in historical signing rate beyond the 14 days.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To support the signing info API for operators.
This should be the last PR following the refactoring to make it functional.
Checks