Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore socket parsing error from dispatcher #1198

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Ignore socket parsing error from dispatcher #1198

merged 1 commit into from
Feb 1, 2025

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Feb 1, 2025

Why are these changes needed?

Dispatcher should not return error when a single operator has a malformed socket, it should continue with the rest of the operators.

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim marked this pull request as ready for review February 1, 2025 01:26
@ian-shim ian-shim merged commit a13af02 into Layr-Labs:master Feb 1, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanc dmanc dmanc approved these changes

@supriya-premkumar supriya-premkumar Awaiting requested review from supriya-premkumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-shim @dmanc