Make the signer constructor return an error if it fails #1190
+41
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: litt3 <[email protected]>
Signed-off-by: litt3 <[email protected]>
samlaf
approved these changes
Jan 31, 2025
core/auth/v2/signer.go
Outdated
| privateKeyBytes := common.FromHex(privateKeyHex) | ||
| privateKey, err := crypto.ToECDSA(privateKeyBytes) | ||
| if err != nil { | ||
| log.Fatalf("Failed to parse private key: %v", err) | ||
| return nil, fmt.Errorf("create ECDSA private key: %v", err) |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("create ECDSA private key: %v", err) | |
| return nil, fmt.Errorf("create ECDSA private key: %w", err) |
There was a problem hiding this comment.
Gah, once again! Fixed fc4e34ebc
api/clients/v2/payload_disperser.go
Outdated
| return nil, fmt.Errorf("invalid length for signer private key") | ||
| signer, err := auth.NewLocalBlobRequestSigner(payloadDispCfg.SignerPaymentKey) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("new local blob request signer: %v", err) |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("new local blob request signer: %v", err) | |
| return nil, fmt.Errorf("new local blob request signer: %w", err) |
Signed-off-by: litt3 <[email protected]>
cody-littley
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Checks