swap g2 A0, A1 for X and Y #1184
Conversation
bxue-l2
requested review from
ian-shim,
cody-littley,
samlaf,
jianoaix and
litt3
core/v2/serialization_test.go
Outdated
| // afa39b4c45197f0254f7e8e2127c797c74578357e9f077eab7a8aa62e1402bec has not verified in solidity | ||
| assert.Equal(t, "afa39b4c45197f0254f7e8e2127c797c74578357e9f077eab7a8aa62e1402bec", hex.EncodeToString(hash[:])) |
There was a problem hiding this comment.
does this mean you computed the hash onchain by calling the smart contract by hand and then posted the code here? Shouldn't we just have an integration test instead that hashes offchain and onchain and makes sure they are equal?
There was a problem hiding this comment.
These are done in chisel with a script that constructs the same struct. @bxue-l2 can you update this when you've done the validation?
There was a problem hiding this comment.
There was a problem hiding this comment.
Still unclear as to how this is computed How could I reproduce using chisel? Bowen did you really use chisel? Do you have to like load the contract and then call the function? Still feel like an automated test would be way better... do we have one?
core/v2/serialization_test.go
Outdated
| // afa39b4c45197f0254f7e8e2127c797c74578357e9f077eab7a8aa62e1402bec has not verified in solidity | ||
| assert.Equal(t, "afa39b4c45197f0254f7e8e2127c797c74578357e9f077eab7a8aa62e1402bec", hex.EncodeToString(hash[:])) |
There was a problem hiding this comment.
These are done in chisel with a script that constructs the same struct. @bxue-l2 can you update this when you've done the validation?
bxue-l2
force-pushed
the
swap-g2-serialization-when-generating-the-merkle-proof
branch
from
75da7d7 to
4a04c81
Compare
This PR addresses the inconsistency issue when serializing the blobHeader at the controller side and at the client side.
When the controller computes a merkle tree for a batch, it serialize all Blobheader into leaves in the tree, and generate merkle proof for each blob. The merkle proof is given to the client, who computes the leaf locally and query the smart contract for the merkle verification.
Because two serialization are different, the merkle proof won't verify.
Note, the G2 serialization only affect G2 inside the blobCommitment. Not the one inside attestation.ApkG2 . The serialization in attestation.ApkG2 is A1, A0.
The BlobCommitments is not used for computation at all. So it is purely just standardizing the serialization format for G2. As it will be weird that we do both serialization in the codebase.
In the current integration test, it called VerifyDACertV2FromSignedBatch.
But in the client, we used an upgraded version called VerifyDACertV2.