Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

187-add-form-validation-for-url-text-inputs #266

Merged
merged 2 commits into from
Apr 28, 2024
Merged

187-add-form-validation-for-url-text-inputs #266

merged 2 commits into from
Apr 28, 2024

Conversation

AmirAgassi
Copy link
Member

🔗 Add form validation for URL text inputs #187

🔍 What's Included

  • Implemented URL validation into text input components to ensure correct URL format.

📁 Files Affected:

  • src/components/TextInput/TextInput.tsx
  • src/components/forms/hackerApplication.ts
  • src/pages/Application/Application.page.tsx

@AmirAgassi AmirAgassi self-assigned this Apr 23, 2024
@AmirAgassi AmirAgassi linked an issue Apr 23, 2024 that may be closed by this pull request
Add form validation for URL text inputs #187
Closed
@juancwu
Copy link
Contributor

juancwu commented Apr 23, 2024

I think the easier solution is to validate the url using zod that is already being used in ApplicationsPage

juancwu
juancwu approved these changes Apr 23, 2024
View reviewed changes
src/components/forms/hackerApplication.ts Outdated Show resolved Hide resolved
@juancwu
Copy link
Contributor

juancwu commented Apr 23, 2024

https://zod.dev/?id=strings

juancwu
juancwu requested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@juancwu juancwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mistake approval

@juancwu juancwu force-pushed the 187-add-form-validation-for-url-text-inputs branch from 79c698e to 7ec0173 Compare April 28, 2024 00:16
@juancwu juancwu merged commit bbd38ca into dev Apr 28, 2024
3 checks passed
@juancwu juancwu deleted the 187-add-form-validation-for-url-text-inputs branch April 28, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancwu juancwu juancwu approved these changes

@aidantrabs aidantrabs Awaiting requested review from aidantrabs aidantrabs is a code owner

@SherRao SherRao Awaiting requested review from SherRao SherRao is a code owner

Assignees

@AmirAgassi AmirAgassi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add form validation for URL text inputs
2 participants
@AmirAgassi @juancwu