Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap multiple SQL statements in a single transaction and share the database connection to drastically speed up the write speed of the function decompilaton results during the initial analysis.
This is a simple initial solution to the problem, perhaps you want to handle it differently. My suggestions to improve this further (perhaps as a later step through another PR) would be to:
SyntaxParser
from theSQLiteDBHandler
so you don't need to pass in the connection as an argument every time. We could work with callbacks instead and let theSQLiteDBHandler
handle all the database operations.updateFunctionDecompilation
in another thread, so theSyntaxParser
can do its work in the background while the main thread moves on to the next function. Database operations should still be atomic, thanks to the added transactions.I only tested these changes with one IPA file. Please verify that everything still works as expected before merging!
Fixes #8.