Skip to content

Commit

Permalink
Remove warp point comp from map beacons (DeltaV-Station#79)
Browse files Browse the repository at this point in the history
## Mirror of PR DeltaV-Station#968: [Remove warp point comp from map
beacons](DeltaV-Station#968) from <img
src="https://avatars.githubusercontent.com/u/131613340?v=4"
alt="DeltaV-Station" width="22"/>
[DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v)

<aside>PR opened by <img
src="https://avatars.githubusercontent.com/u/107660393?v=4"
width="16"/><a href="https://github.com/IamVelcroboy"> IamVelcroboy</a>
at 2024-03-16 14:13:15 UTC</aside>
<aside>PR merged by <img
src="https://avatars.githubusercontent.com/u/107660393?v=4"
width="16"/><a href="https://github.com/IamVelcroboy"> IamVelcroboy</a>
at 2024-03-28 04:53:19 UTC</aside>
<sup>

`40eeef24e7685a2bb2b2b35396fb546a38e96216`

</sup>

---

PR changed 0 files with 0 additions and 0 deletions.

The PR had the following labels:
- Changes: YML
- Status: Needs Review


---

<details open="true"><summary><h1>Original Body</h1></summary>

> ## About the PR
> Title
> 
> ## Why / Balance
> Makes things much cleaner. Currently we have Warp Point markers,
Bombing Targets, and Map Beacons all with an overlapping function. (Also
Warp points+Beacons markers but I'm ignoring those for this.)
> 
> **Why it's messy** 
> Standard warp points and bombing targets can be used interchangeably.
You can use a WP where you don't want a target, use a BT where you do.
Beacons, on the other hand, don't have BT but double up as a WP. So, you
either end up having to choose between a BT/WP or a beacon, or double up
a location on the Ghost Warp menu. Additionally, just using beacons
bloats the Warp Menu.
> 
> Beacons can be moved by players. So, attaching either WP or BT to
those is bad. Beacons are really nice, both for mappers and players but
as long as they have WP, it causes conflict for mappers and/or bloat in
the Ghost Warp menu.
> 
> **Solution**
> For Delta V we will use WP and BT to fill the Ghost Warp menu and
Beacons for the Navmap. Problem solved/potential griefing, issues, etc.
avoided, and no more Warp Menu bloat.
>  
> ## Technical details
> - Some maps will likely need to be adjusted for this change.
> - Attempted to upstream this was denied. Solution proposed causes more
work and less clear instructions for mappers.


</details>

Co-authored-by: Velcroboy <[email protected]>
Co-authored-by: VMSolidus <[email protected]>
  • Loading branch information
3 people authored May 9, 2024
1 parent cfd943c commit dd3fd52
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
- type: entity
parent: DefaultStationBeaconMedical
id: DefaultStationBeaconExam
suffix: Exam Room
suffix: Exam
components:
- type: NavMapBeacon
text: station-beacon-exam
Expand All @@ -43,7 +43,7 @@
- type: entity
parent: DefaultStationBeaconMedical
id: DefaultStationBeaconPsychologist
suffix: Psychologist
suffix: Psych
components:
- type: NavMapBeacon
text: station-beacon-psych
Expand All @@ -52,15 +52,15 @@
- type: entity
parent: DefaultStationBeaconScience
id: DefaultStationBeaconProber
suffix: Glimmer Prober
suffix: Prober
components:
- type: NavMapBeacon
text: station-beacon-glimmer-prober

- type: entity
parent: DefaultStationBeaconScience
id: DefaultStationBeaconMantis
suffix: Forensic Mantis
suffix: Mantis
components:
- type: NavMapBeacon
text: station-beacon-forensic-mantis
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
- type: NavMapBeacon
text: station-beacon-general
color: "#D4D4D496"
- type: WarpPoint
#- type: WarpPoint # Delta V - Removes in favor of Warp Point Markers
- type: ActivatableUI
key: enum.NavMapBeaconUiKey.Key
singleUser: true
Expand Down

0 comments on commit dd3fd52

Please sign in to comment.