[gccjit][memref] fix alloca builtin names

It is still not working due to ICE inside `libgccjit`, but it resolves all the builtins now.
Lancern · Nov 9, 2024 · 795d97f · 795d97f
1 parent 9f64961
commit 795d97f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 14 deletions.
diff --git a/src/Conversion/ConvertMemrefToGCCJIT.cpp b/src/Conversion/ConvertMemrefToGCCJIT.cpp
@@ -555,23 +555,24 @@ struct AllocaOpLowering : public AllocationLowering<memref::AllocaOp> {
     if (auto align = op.getAlignment()) {
       auto alignment =
           createIndexAttrConstant(rewriter, loc, getIndexType(), *align);
+      alloca =
+          rewriter
+              .create<CallOp>(loc, getVoidPtrType(),
+                              SymbolRefAttr::get(rewriter.getContext(),
+                                                 "__builtin_alloca_with_align"),
+                              ValueRange{size, alignment},
+                              /* tailcall */ nullptr,
+                              /* builtin */ rewriter.getUnitAttr())
+              .getResult();
+    } else {
       alloca = rewriter
                    .create<CallOp>(loc, getVoidPtrType(),
                                    SymbolRefAttr::get(rewriter.getContext(),
-                                                      "alloca_with_align"),
-                                   ValueRange{size, alignment},
+                                                      "__builtin_alloca"),
+                                   ValueRange{size},
                                    /* tailcall */ nullptr,
                                    /* builtin */ rewriter.getUnitAttr())
                    .getResult();
-    } else {
-      alloca = rewriter
-                   .create<CallOp>(
-                       loc, getVoidPtrType(),
-                       SymbolRefAttr::get(rewriter.getContext(), "alloca"),
-                       ValueRange{size},
-                       /* tailcall */ nullptr,
-                       /* builtin */ rewriter.getUnitAttr())
-                   .getResult();
     }
     alloca = rewriter.create<BitCastOp>(loc, elementPtrType, alloca);
     rewriter.create<ReturnOp>(loc, alloca);

diff --git a/test/lowering/alloca.mlir b/test/lowering/alloca.mlir
@@ -4,19 +4,19 @@ module @test
 {
 
   func.func @foo() {
-    // CHECK: gccjit.call  builtin @alloca(%{{[0-9]+}}) : (!gccjit.int<size_t>) -> !gccjit.ptr<!gccjit.void>
+    // CHECK: gccjit.call  builtin @__builtin_alloca(%{{[0-9]+}}) : (!gccjit.int<size_t>) -> !gccjit.ptr<!gccjit.void>
     %a = memref.alloca () : memref<100x100xf32>
     return 
   }
 
   func.func @bar(%arg0 : index) {
-    // // CHECK: gccjit.call  builtin @alloca(%{{[0-9]+}}) : (!gccjit.int<size_t>) -> !gccjit.ptr<!gccjit.void>
+    // // CHECK: gccjit.call  builtin @__builtin_alloca(%{{[0-9]+}}) : (!gccjit.int<size_t>) -> !gccjit.ptr<!gccjit.void>
     %a = memref.alloca (%arg0) : memref<133x723x?xf32>
     return
   }
 
   func.func @baz(%arg0 : index) {
-    // CHECK: gccjit.call  builtin @alloca_with_align(%{{[0-9]+}}, %{{[0-9]+}}) : (!gccjit.int<size_t>, !gccjit.int<size_t>) -> !gccjit.ptr<!gccjit.void>
+    // CHECK: gccjit.call  builtin @__builtin_alloca_with_align(%{{[0-9]+}}, %{{[0-9]+}}) : (!gccjit.int<size_t>, !gccjit.int<size_t>) -> !gccjit.ptr<!gccjit.void>
     %a = memref.alloca (%arg0) {alignment = 128} : memref<133x723x?xf32>
     return
   }