Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning for empty bins in ClusterEnsemble #652

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

m-aguena
Copy link
Collaborator

Closes issue #618 , second interaction

@m-aguena m-aguena marked this pull request as draft November 18, 2024 17:48
@m-aguena m-aguena linked an issue Nov 18, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Nov 19, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling fa84ad6 on issue/618/empty_radial_bin_again
into cfa7f11 on main.

@marina-ricci
Copy link
Collaborator

Just to copy here what we discussed : we want to return NaN instead of 0 when there are empty bins.

@m-aguena m-aguena marked this pull request as ready for review November 20, 2024 11:05
@m-aguena
Copy link
Collaborator Author

Just to copy here what we discussed : we want to return NaN instead of 0 when there are empty bins.

done!

@combet
Copy link
Collaborator

combet commented Feb 12, 2025

Thank you @m-aguena - I just had a quick look, starting by running the demo_mock_ensemble notebook to check things out.

  • I'm not sure I understand the output of cell 15. The legend says there should be dashed lines for "all table" but we only see solid lines in the figure.

  • Something else changed and the covariance matrices later do not look like at all what they used to. Cf figures below when running from main and from this branch.

From main:
Screenshot 2025-02-12 at 17 31 28

From this branch:
Screenshot 2025-02-12 at 17 33 35

@combet
Copy link
Collaborator

combet commented Feb 13, 2025

Ah, I see, it's because maximum=nan in that cell (probably because of the new nan values in empty bins?), so the colorscale is not doing what it should...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow empty radial bins in cluster ensemble
4 participants