-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with Numpy 2.0 #231
Open
jaimergp
wants to merge
22
commits into
LLNL:develop
Choose a base branch
from
jaimergp:numpy2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Build with Numpy 2.0 #231
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
b251f64
Use Numpy 2.0
jaimergp 859ca72
update this requirement too
jaimergp 2fb939d
Ask for py39
jaimergp d3ba030
Add PR triggers for workflows, and control for concurrency
jaimergp 82e225e
Merge branch 'develop' into numpy2
jaimergp a3e75dc
All pushes trigger workflows
jaimergp 14f6c99
Force Python3 in Appveyor?
jaimergp 5d92985
enable interactive debugging temporarily
jaimergp 2af8987
Adjust VM images
jaimergp b03dc38
exit if PYTHON_DIR does not exist
jaimergp b2daf40
python3 doesn't exist; use pip3
jaimergp e284c5b
negate equality
jaimergp 5974a8c
revert to powershell here
jaimergp 0335986
exists -> exist
jaimergp 65fecfe
adjust generator
jaimergp cf073f1
use -A instead of architecture in -G
jaimergp cd5d726
debug again
jaimergp ce547a5
remove PYTHON_INCLUDE_DIR workarounds
jaimergp f05d9d2
do not debug
jaimergp 62ba300
define PYTHON_INCLUDE_DIR
jaimergp 642846c
pass PYTHON_INCLUDE_DIR
jaimergp b5212a7
pass directly
jaimergp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
cython>=0.22 | ||
numpy>=1.8.0 | ||
numpy>=2.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this a runtime requirements file or a build time requirements file? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ | |
author_email="[email protected]", | ||
url="https://zfp.llnl.gov", | ||
description="zfp compression in Python", | ||
python_requires=">=3.9", | ||
long_description="zfp is a compressed format for representing multidimensional floating-point and integer arrays. zfp provides compressed-array classes that support high throughput read and write random access to individual array elements. zfp also supports serial and parallel compression of whole arrays using both lossless and lossy compression with error tolerances. zfp is primarily written in C and C++ but also includes Python and Fortran bindings.", | ||
ext_modules=[Extension("zfpy", ["build/python/zfpy.c"], | ||
include_dirs=["include", np.get_include()], | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think these MinGW builds also need Python version set to 3.9. Appears they use Python 2.7 otherwise