Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split main.rs into separate modules and library crate #26

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

nightlark
Copy link
Collaborator

Adds some organization using modules instead of everything being in main.rs to prepare for future development, and moves most of the logic to a library crate that gets used by the main dapper binary so that people could potentially use dapper as a dependency in other projects.

@nightlark nightlark requested a review from Copilot December 20, 2024 22:12
@nightlark nightlark self-assigned this Dec 20, 2024
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • src/walker.rs: Evaluated as low risk

src/parser.rs Outdated Show resolved Hide resolved
nightlark added a commit that referenced this pull request Dec 20, 2024
Adds some organization using modules instead of everything being in
main.rs to prepare for future development, and moves most of the logic
to a library crate that gets used by the main dapper binary so that
people could potentially use dapper as a dependency in other projects.
@nightlark nightlark force-pushed the refactor-into-modules branch from ff71f26 to da7cd53 Compare December 20, 2024 22:20
Adds some organization using modules instead of everything being in
main.rs to prepare for future development, and moves most of the logic
to a library crate that gets used by the main dapper binary so that
people could potentially use dapper as a dependency in other projects.
@nightlark nightlark force-pushed the refactor-into-modules branch from da7cd53 to da3e605 Compare December 20, 2024 22:21
@nightlark nightlark requested a review from Copilot December 20, 2024 22:21

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/main.rs: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/parser.rs:54

  • [nitpick] The error message could be more informative by including the node information. Suggested change: eprintln!("Error reading include name as utf8 text from {} at node {:?}: {}", file_path, node, e);
eprintln!("Error reading include name as utf8 text from {}: {}", file_path, e);
@nightlark nightlark merged commit da3e605 into main Dec 20, 2024
5 checks passed
@nightlark nightlark deleted the refactor-into-modules branch December 20, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant