Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update parsing of system definitions for table #573

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

slabasan
Copy link
Collaborator

@slabasan slabasan commented Jan 25, 2025

Description

  • Update parsing of system definitions for table in docs, move existing table to a legacy catalog of systems
  • No dependencies
  • Part of Docs: new csv generation for system and benchmark lists #377
  • Complete the checklist for a relevant section(s) below
  • Delete sections below that are not relevant to this PR
  • Update to current develop: all_system_definitions was renamed to all_hardware_descriptions, all system_definition.yaml were renamed to hardware_description.yaml

Open questions:

  • Caliper is listed under experiments, but isn't considered a benchmark, should it be appearing in the benchpark list benchmarks command? Move caliper from experiment to lib #577 fixed this.
  • Systems table is creating additional columns that I think were meant to be rows. See systems-tested.csc-lumi and systems-tested.llnl-elcapitan columns in screenshot below.

Screenshot 2025-01-27 at 1 29 41 PM

Alternative table (previously, interconnect.name, integrator.vendor):

Screenshot 2025-01-28 at 11 06 37 AM

Adding/modifying core functionality, CI, or documentation:

  • Update docs
  • Update .github/workflows and .gitlab/ci unit tests (if needed)

@slabasan slabasan added docs Improvements or additions to documentation WIP A work-in-progress not yet ready to commit labels Jan 25, 2025
@slabasan slabasan force-pushed the docs/update-system-definition-table-generate branch 3 times, most recently from 00b28a2 to e0990be Compare January 25, 2025 18:38
@slabasan slabasan changed the title docs: update parsing of system definitions for table docs: update parsing of system definitions and benchmarks for tables Jan 26, 2025
@slabasan slabasan changed the title docs: update parsing of system definitions and benchmarks for tables docs: update parsing of system definitions for table Jan 27, 2025
move existing table to a legacy catalog of systems
@slabasan slabasan force-pushed the docs/update-system-definition-table-generate branch from e0990be to 4d2a417 Compare January 27, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation WIP A work-in-progress not yet ready to commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant