Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizing system names #560

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Standardizing system names #560

wants to merge 9 commits into from

Conversation

pearce8
Copy link
Collaborator

@pearce8 pearce8 commented Jan 23, 2025

Description

Making system names follow site-system name conventions.

Dependencies: none.

Fixes issue(s): none.

Type of Change

  • { } Adding a system, benchmark, or experiment
  • {X} Modifying an existing system, benchmark, or experiment
  • { } Documentation update
  • { } Build/CI update
  • { } Benchpark core functionality

Checklist:

If adding/modifying a system:

  • {X} Create a new directory for the system and a new system.py file
  • {X} Add a new dry run unit test in .github/workflows
  • {X} System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

  • { } Add a new application.py and (maybe) package.py under a new directory
    for this benchmark
  • { } Configure an experiment
  • { } Benchmark appears in Benchmarks and Experiments table in docs catalogue
    section

If adding/modifying a experiment:

  • { } Extend experiment.py under existing directory for specific benchmark
  • { } Define a single node and multi-node experiments

If adding/modifying core functionality:

  • { } Update docs
  • { } Update .github/workflows and .gitlab/ci unit tests (if needed)

@github-actions github-actions bot added the ci Involving Project CI & Unit Tests label Jan 23, 2025
@pearce8 pearce8 requested a review from rfhaque January 23, 2025 09:05
@pearce8
Copy link
Collaborator Author

pearce8 commented Jan 23, 2025

@rfhaque Can you please figure out what I missed in the dry runs, and review? I would like to merge this to make our system naming more uniform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Involving Project CI & Unit Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant