Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding hpcg experiment class #525

Merged
merged 24 commits into from
Jan 30, 2025
Merged

Adding hpcg experiment class #525

merged 24 commits into from
Jan 30, 2025

Conversation

august-knox
Copy link
Collaborator

@august-knox august-knox commented Jan 6, 2025

Description

Adding hpcg experiment class. Contains strong & weak scaling, & caliper variant.

Dependencies: Currently using david's branch https://github.com/daboehme/hpcg.git

Fixes issue(s): None

Type of Change

  • {x} Adding a system, benchmark, or experiment
  • { } Modifying an existing system, benchmark, or experiment
  • { } Documentation update
  • { } Build/CI update
  • { } Benchpark core functionality

Checklist:

If adding/modifying a system:

  • { } Create a new directory for the system and a new system.py file
  • { } Add a new dry run unit test in .github/workflows
  • { } System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

  • {x} Add a new application.py and (maybe) package.py under a new directory
    for this benchmark
  • {x} Configure an experiment
  • {x} Benchmark appears in Benchmarks and Experiments table in docs catalogue
    section

If adding/modifying a experiment:

  • {x} Extend experiment.py under existing directory for specific benchmark
  • {x} Define a single node and multi-node experiments

If adding/modifying core functionality:

  • { } Update docs
  • { } Update .github/workflows and .gitlab/ci unit tests (if needed)

@github-actions github-actions bot added experiment New or modified experiment ci CI, unit tests, GitHub actions application labels Jan 6, 2025
@august-knox august-knox requested a review from rfhaque January 6, 2025 21:35
@august-knox august-knox added the ready for review Ready for review label Jan 8, 2025
Comment on lines 95 to 97
self.add_spack_spec(
self.name, [f"hpcg@{app_version} +openmp", system_specs["compiler"]]
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@august-knox Instead of hard-coding +openmp, we should add the openmp variant to this experiment.

@rfhaque rfhaque merged commit b9d39d0 into develop Jan 30, 2025
9 checks passed
@rfhaque rfhaque deleted the experiment/hpcg branch January 30, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application ci CI, unit tests, GitHub actions experiment New or modified experiment ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants